Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings from recent GCCs #479

Closed
wants to merge 9 commits into from
Closed

Fix warnings from recent GCCs #479

wants to merge 9 commits into from

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 14, 2019 •
edited
Loading

Changes

  • Explicitly specify the namespace as ::dart::common::make_unique() to avoid the ambiguity with std::make_unique()
  • Remove used of deprecated API in DART 6.7

This PR depends on #478.

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 closed this Jan 14, 2019
This was referenced Jan 14, 2019
Merged
Merged
@jslee02 jslee02 deleted the make_unique branch January 17, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jslee02