Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling dart::common::make_unique() with recent GCC versions #481

Merged
merged 4 commits into from
Jan 17, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 14, 2019

Explicitly specify the namespace as ::dart::common::make_unique() to avoid the ambiguity with std::make_unique().

Note that this PR won't pass the CIs (for Ubuntu >= 14.04) until the issues of gtest and #480. I breakdown #479 into smaller ones to make the review process, and this is one of them.


Before creating a pull request

  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md

@jslee02 jslee02 requested a review from brianhou January 14, 2019 22:44
@brianhou
Copy link
Contributor

My guess is that this is a problem when using a compiler that supports C++14 features -- is that correct?

@jslee02
Copy link
Member Author

jslee02 commented Jan 15, 2019

My guess is that this is a problem when using a compiler that supports C++14 features -- is that correct?

Exactly!

brianhou
brianhou previously approved these changes Jan 16, 2019
@jslee02 jslee02 added this to the Aikido 0.3.0 milestone Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants