Fix compiling dart::common::make_unique() with recent GCC versions #481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly specify the namespace as
::dart::common::make_unique()
to avoid the ambiguity withstd::make_unique()
.Note that this PR won't pass the CIs (for Ubuntu >= 14.04) until the issues of gtest and #480. I breakdown #479 into smaller ones to make the review process, and this is one of them.
Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md