-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pybind11 manual bindings #499
Conversation
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
=========================================
Coverage ? 77.85%
=========================================
Files ? 262
Lines ? 6768
Branches ? 0
=========================================
Hits ? 5269
Misses ? 1499
Partials ? 0 |
…World, ConcreteManipulator, CollisionFree to pybind11
…/aikido into pybind11_manual
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete the .swp file committed in b0691c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly left comments on the README. Can you also explain what the difference is between aikidopy.cpp
and aikido_py.cpp
?
Hmm I was following @jslee02 's example code I got for herbpy so @jslee02 might have a better answer (or suggestions). My understanding is that |
I use It seems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current CMake script seems to be meant to build aikidopy assuming AIKIDO is already installed. If that's the case, I suggest having adikiopy in a separate repo. Otherwise, please:
- remove
find_package(DART ...)
, which is already called, and the variables (i.e.,DART_INCLUDE_DIRS
andDART_LIBRARIES
) - remove
find_package(AIKIDO ...)
, and use the necessary targets (e.g.,aikido-common
,aikido-statespace
, and so on).
This PR contains minimal class definitions for exposing aikido classes needed for other repositories such as libherb and pr_tsr.
The python binding is built not part of aikido but as a separate project after aikido is built via catkin.
Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md