Some Windows fixes #41

Pierstoval · 2020-05-28T21:16:18Z

Binary was using realpath, and targets were sanitized without taking the full path's drive name in account, so this was fixed.

I intend to wait for CI to make sure the test suite still works as expected.

I hope it'll fix #36 🤔

nunomaduro

This sounds good to me. A second validation would be nice here, @olivernybroe @owenvoke ?

owenvoke

This looks ok to me. Damn Windows support. sigh I've tested it locally on my Windows machine and most of the tests are successful. 👍

However, as per #37, the tests still aren't actually being executed here on Windows despite the CI passing. 👍

~~I'll have another look in the morning though.~~

Ok, I've re-tested on my proper Windows dev machine. The following tests seem to fail:

The first 3 tests fail due to not having the trait methods available, so I don't think uses() is working as expected. 🤔

The visual tests fail with the following:

Failed asserting that '' contains " PASS Tests\Fixtures\DirectoryWithTests\ExampleTest

@Pierstoval, were all tests passing on your Windows machine? 🤔

nunomaduro · 2020-05-29T18:12:20Z

nunomaduro · 2020-05-29T18:13:25Z

@Pierstoval Can you rebase buddy? The fix of the build is now on the master.

nunomaduro · 2020-05-29T18:27:02Z

Yup, couple of tests on windows are failing. This is good sign.

Pierstoval · 2020-05-29T19:51:42Z

Locally, Pest tests work, but i have some that fail:

   WARN  EdevwwwpesttestsFeaturesSkip
  ✓ it do not skips
  s it skips with truthy
  s it skips with truthy condition by default
  s it skips with message → skipped because bar
  s it skips with truthy closure condition
  ✓ it do not skips with falsy closure condition
  s it skips with condition and message → skipped because foo

   FAIL  EdevwwwpesttestsPHPUnitCustomTestCaseInSubFoldersSubFolderSubFolderUsesPerSubDirectory
  • closure was bound to  custom test case

   FAIL  EdevwwwpesttestsPHPUnitCustomTestCaseUsesPerDirectory
  • closure was bound to  custom test case

   FAIL  EdevwwwpesttestsPluginsTraits
  • it allows global uses

   FAIL  EdevwwwpesttestsVisualSingleTestOrDirectory
  • allows to run a single test
  • allows to run a directory

(sorry, output is not really easy to copy to github 😅 )

owenvoke · 2020-05-29T20:09:14Z

Yeah, I was trying to work those out earlier. 🤔 (#41 (review))

Pierstoval · 2020-05-29T20:12:32Z

Some tests are related to the fact that php isn't called, and bin/pest is, I'm investigating :)

Pierstoval · 2020-05-29T20:34:33Z

Another issue is how test names are displayed in the output, I've got this issue after a fix:

 $ php bin/pest tests\Visual\SingleTestOrDirectory.php

   FAIL  EdevwwwpesttestsVisualSingleTestOrDirectory
  • allows to run a single test
  • allows to run a directory

  ---

  • EdevwwwpesttestsVisualSingleTestOrDirectory > allows to run a single test
  Failed asserting that '\n
     PASS  TestsFixturesDirectoryWithTestsExampleTest\r\n
    ✓ it example\r\n
  \n
    Tests:  1 passed\r\n
    Time:   0.04s\r\n
  ' contains "   PASS  Tests\Fixtures\DirectoryWithTests\ExampleTest
    ✓ it example

    Tests:  1 passed".

As you can see, the test name should be Tests\Fixtures\DirectoryWithTests\ExampleTest, but it's displayed as TestsFixturesDirectoryWithTestsExampleTest.

I'm trying to search where this could be done... @nunomaduro, any idea?

nunomaduro · 2020-05-29T20:54:32Z

@Pierstoval Here: https://github.com/nunomaduro/collision/blob/a4ef05049dbefcacef5081ce34943dc4ef8106fa/src/Adapters/Phpunit/TestResult.php#L113.

Pierstoval · 2020-05-29T22:16:07Z

I made a few changes, it's still investigation more than bug fixes since I'm only testing this on Windows.

(EDIT: At least, tests are executing in most Windows CI!)

I'm totally unsure of 6fb3c79 since I don't know what's going to be the impact on Linux 🤔 but I was unsure about using basename() since it didn't display the full test name, instead was just displaying the class name and not its FQN in the test output.

By default, with basename(), I get this:

$ php bin/pest tests\Visual\SingleTestOrDirectory.php

   FAIL  SingleTestOrDirectory
  • allows to run a single test
  • allows to run a directory

  ---

  • SingleTestOrDirectory > allows to run a single test
  Failed asserting that '\n
     PASS  ExampleTest\r\n
    ✓ it example\r\n
  \n
    Tests:  1 passed\r\n
    Time:   0.04s\r\n
  ' contains "   PASS  Tests\Fixtures\DirectoryWithTests\ExampleTest
    ✓ it example

    Tests:  1 passed".

If I replace basename() with the preg_replace() in 6fb3c79 , I get this:

$ php bin/pest tests\Visual\SingleTestOrDirectory.php

   FAIL  Tests\Visual\SingleTestOrDirectory
  • allows to run a single test
  • allows to run a directory

  ---

  • Tests\Visual\SingleTestOrDirectory > allows to run a single test
  Failed asserting that '\n
     PASS  E\dev\www\pest\tests\Fixtures\DirectoryWithTests\ExampleTest\r\n
    ✓ it example\r\n
  \n
    Tests:  1 passed\r\n
    Time:   0.04s\r\n
  ' contains "   PASS  Tests\Fixtures\DirectoryWithTests\ExampleTest
    ✓ it example

    Tests:  1 passed".

There seem to be tons of things related to paths and root dir, I'm not sure where to search next🤔

Pierstoval · 2020-05-29T22:16:44Z

(marked it as draft because it seems it's definitely NOT ready to be merged)

nunomaduro · 2020-05-29T22:22:40Z

src/Factories/TestCaseFactory.php

@@ -152,15 +152,23 @@ public function build(TestSuite $testSuite): array
     */
    public function makeClassFromFilename(string $filename): string
    {
+        if ('\\' === DIRECTORY_SEPARATOR) {


This will only happen on windows?

Might be better to just use PHP_OS_FAMILY === 'Windows'?

Yep this can happen only on Windows, that's a fairly common case 🙂

nunomaduro · 2020-05-31T13:25:29Z

@Pierstoval Hey buddy, you are still working on this correct? Its fine if takes weeks, I just wanna make sure that there is no action on my side to be done.

Pierstoval · 2020-05-31T17:15:24Z

For now, I need to check why tests are failing, but I'm a bit busy these days :)

nunomaduro · 2020-05-31T17:17:12Z

No problem. Going to mark this issue as needs help. Maybe someone can take over.

dimitrioskarvounaris · 2020-05-31T23:51:14Z

So, what exactly is here more required? Can you elaborate a little more?

nunomaduro · 2020-06-01T00:08:04Z

Sure, normally if you are on windows you can reproduce the problem running: composer test:unit.

Pierstoval · 2020-06-02T07:18:48Z

@dimitrioskarvounaris The tests must be fully working on Windows, which is not the case now

dimitrioskarvounaris · 2020-06-02T15:14:23Z

Continuing work under https://github.com/dimitrioskarvounaris/pest/tree/windows-gitbash
I got the pull request with the github-cli and then tried to push it to my repo to not create separate branches and maybe add it on top of this one, but it will keep asking permissions to Pierstoval's repo to commit on the same branch, even though remote url points to my fork. If you know a workaround to this, let me know.

Pierstoval · 2020-06-02T15:36:04Z

@dimitrioskarvounaris feel free to make PRs on my fork to add your commits to this PR, I will accept them right away without review so they can be reviewed right here instead :)

dimitrioskarvounaris · 2020-06-02T17:20:06Z

Felt it was too much trouble, to have one more fork (if that would even work at all, to make a fork from a fork, while having another fork of the original repo), and github wouldn't let me push to the same branch even on my fork, as I used the github-cli to clone the pull request. Github docs also said, I would need still push permissions on the other fork... sorry... so I just made a new PR here instead of going through all the trouble: #61 - it contains though all previous commits too. This way, I can use the extra time I would have lost trying that (and maybe still not working) in fixing the integration tests, instead.

nunomaduro · 2020-06-04T16:51:46Z

This is the branch that contains the windows work? If yes, can you close the other one @dimitrioskarvounaris?

nunomaduro · 2020-06-04T21:10:10Z

I've removed windows for now: e8d426f.

Fell free to put it back.

dimitrioskarvounaris · 2020-06-05T09:54:06Z

@nunomaduro Branch "windows-gitbash" contains Pierstoval's as also my fixes, not "windows". #61 fixes everything and the tests pass (I run them on windows as also linux).

nunomaduro · 2020-06-05T14:06:03Z

Closing in favour of #61.

dkarvounaris · 2021-08-07T14:39:50Z

Dear colleagues, I am working on software engineering research and request your cooperation in answering this survey: https://forms.gle/h2D6cfjJM6rtSV456

It will only take you 10 minutes.

Excuse me, thank you very much for your help.

Is this some spam?

Pierstoval mentioned this pull request May 28, 2020

Builds failing on windows #36

Closed

nunomaduro approved these changes May 28, 2020

View reviewed changes

owenvoke reviewed May 28, 2020

View reviewed changes

Pierstoval mentioned this pull request May 29, 2020

Fix Windows builds running Pest #37

Merged

Pierstoval marked this pull request as draft May 29, 2020 22:16

nunomaduro reviewed May 29, 2020

View reviewed changes

nunomaduro added the help wanted label May 31, 2020

nunomaduro mentioned this pull request May 31, 2020

#53 Recognize absolute paths under Windows #54

Closed

dimitrioskarvounaris mentioned this pull request Jun 2, 2020

Fixes autoloading, plugins and tests on Windows #61

Merged

Pierstoval added 2 commits June 3, 2020 10:28

Don't use "reapath" in binary for cross-compatibility

ffe3c3e

Make sure test targets are sanitized in a windows-compatible way

ba66ef1

Pierstoval added 3 commits June 3, 2020 10:28

Make sure PHP is called before calling pest as sub process

8279651

Normalize Windows dir name in TestCaseFactory

df92730

Not sure about this commit 🤔

2297d25

nunomaduro closed this Jun 5, 2020

Pierstoval deleted the windows branch April 19, 2021 08:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some Windows fixes #41

Some Windows fixes #41

Pierstoval commented May 28, 2020 •

edited

Loading

nunomaduro left a comment

owenvoke left a comment •

edited

Loading

nunomaduro commented May 29, 2020

nunomaduro commented May 29, 2020

nunomaduro commented May 29, 2020

Pierstoval commented May 29, 2020

owenvoke commented May 29, 2020

Pierstoval commented May 29, 2020 •

edited

Loading

Pierstoval commented May 29, 2020

nunomaduro commented May 29, 2020

Pierstoval commented May 29, 2020 •

edited

Loading

Pierstoval commented May 29, 2020

nunomaduro May 29, 2020

owenvoke May 29, 2020

Pierstoval May 30, 2020

nunomaduro commented May 31, 2020

Pierstoval commented May 31, 2020

nunomaduro commented May 31, 2020

dimitrioskarvounaris commented May 31, 2020

nunomaduro commented Jun 1, 2020

Pierstoval commented Jun 2, 2020

dimitrioskarvounaris commented Jun 2, 2020

Pierstoval commented Jun 2, 2020

dimitrioskarvounaris commented Jun 2, 2020 •

edited

Loading

nunomaduro commented Jun 4, 2020

nunomaduro commented Jun 4, 2020

dimitrioskarvounaris commented Jun 5, 2020 •

edited

Loading

nunomaduro commented Jun 5, 2020

dkarvounaris commented Aug 7, 2021

Some Windows fixes #41

Some Windows fixes #41

Conversation

Pierstoval commented May 28, 2020 • edited Loading

nunomaduro left a comment

Choose a reason for hiding this comment

owenvoke left a comment • edited Loading

Choose a reason for hiding this comment

nunomaduro commented May 29, 2020

nunomaduro commented May 29, 2020

nunomaduro commented May 29, 2020

Pierstoval commented May 29, 2020

owenvoke commented May 29, 2020

Pierstoval commented May 29, 2020 • edited Loading

Pierstoval commented May 29, 2020

nunomaduro commented May 29, 2020

Pierstoval commented May 29, 2020 • edited Loading

Pierstoval commented May 29, 2020

nunomaduro May 29, 2020

Choose a reason for hiding this comment

owenvoke May 29, 2020

Choose a reason for hiding this comment

Pierstoval May 30, 2020

Choose a reason for hiding this comment

nunomaduro commented May 31, 2020

Pierstoval commented May 31, 2020

nunomaduro commented May 31, 2020

dimitrioskarvounaris commented May 31, 2020

nunomaduro commented Jun 1, 2020

Pierstoval commented Jun 2, 2020

dimitrioskarvounaris commented Jun 2, 2020

Pierstoval commented Jun 2, 2020

dimitrioskarvounaris commented Jun 2, 2020 • edited Loading

nunomaduro commented Jun 4, 2020

nunomaduro commented Jun 4, 2020

dimitrioskarvounaris commented Jun 5, 2020 • edited Loading

nunomaduro commented Jun 5, 2020

dkarvounaris commented Aug 7, 2021

Pierstoval commented May 28, 2020 •

edited

Loading

owenvoke left a comment •

edited

Loading

Pierstoval commented May 29, 2020 •

edited

Loading

Pierstoval commented May 29, 2020 •

edited

Loading

dimitrioskarvounaris commented Jun 2, 2020 •

edited

Loading

dimitrioskarvounaris commented Jun 5, 2020 •

edited

Loading