Fixes autoloading, plugins and tests on Windows #61
Conversation
|
Sounds a fantastic job. Do you know why tests are failing? |
You mean, if I know, why the tests were failing? Yes, I debugged the code and figured the reason for each one. Some things are posted in Discord. Often - besides the linebreaks - it was that paths would not match, and as such, working on strings where part of path would be replaced or something added, would no longer happen or not happen correctly. Especially, when $rootPath was used. This would even lead to things as having the wrong output next to "PASS", traits not autoloading or plugins not even initializing with the "invalid path exception" when Plugin::uses() (as it sets |
Fixes tests failing under Windows environments for any linebreak character differences
This fixes plugins to be included incorrectly under Windows
Windows requires realpath() so the case of the paths and filenames are always identical
dimitrioskarvounaris
force-pushed
the
windows-gitbash
branch
from
07bde87
to
d35320c
Compare
basename() will strip full path information on some systems. What is needed is to use both dirname() & basename() on paths, as recognized by all systems, and only afterwards do any replacements.
|
@dimitrioskarvounaris @Pierstoval Huge thanks! <3 |
Based on #41 and all tests for
test:unitpass under Windows and Linux.It fixes issues, where otherwise some features wouldn't load or work at all under Windows.