Add default timeout to cache memoize

[KarimTayie]

No description provided.

[peterbe]

Can't you just leave it instead? I.e. if you do:

>>> from django.core.cache import cache
>>> cache.set('foo', 'bar')

it will apply whatever's in django.conf.settings.CACHES["default"].

[peterbe]

Oh I see. I think you can just use:

>>> from django.core.cache import cache
>>> cache.set('foo', 'bar', timeout=object())

is the exact same as not specifying it.

[peterbe]

Actually. It makes sense.

Personally, I never use the default because if you're caching properly you probably need to have better understanding and control over the value because it depends on business logic and the application.

[peterbe]

I can't merge this because the CI tests aren't running. Any idea why?

[KarimTayie]

Hello,
sorry for taking so long to reply.

I can't merge this because the CI tests aren't running. Any idea why?

I can't find the CI tests, can you please show me the logs?

[peterbe]

Let's see if this restarts the CI tests.

[peterbe]

Can you merge in the latest upstream master into your branch and push. Perhaps that'll pick up the new GitHub Actions checks.

[KarimTayie]

From github.com:peterbe/django-cache-memoize
 * branch            master     -> FETCH_HEAD
Already up to date.

already pulled the latest upstream master into this pr.

from this screenshot, all looks good.

[peterbe]

Let's try if close and re-opening triggers the CI tests.

[peterbe]

What the heck?! I don't know why the tests aren't running. I'll have to take a look some day when I have time.

[YPCrumble]

@KarimTayie @peterbe my update in #48 should make the tests run via 8470d5b

[peterbe]

@KarimTayie can you merge in master into your branch and push that that should hopefully fix your tests.

[EmberCraze]

Hey, can we get this done? I can create a similar PR and get the CI to run if needed. Would that be okay?

[peterbe]

Hey, can we get this done? I can create a similar PR and get the CI to run if needed. Would that be okay?

Yeah, start a fresh one.

[EmberCraze]

Hey, can we get this done? I can create a similar PR and get the CI to run if needed. Would that be okay?

Yeah, start a fresh one.

Here it is #68