Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default timout to cache_memoize #68

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

EmberCraze
Copy link
Contributor

In some cases, you do not want to specify the timout for all the definitions and want the method to use the django defult cache timeout instead.

In some cases, you do not want to specify the timout for all the
definitions and want the method to use the django defult cache timeout
instead.
@EmberCraze
Copy link
Contributor Author

This is the same change as #46 but with the latest master as that PR is stale

@peterbe
Copy link
Owner

peterbe commented Dec 16, 2024

Do you think it's worth mentioning this in the README?
Perhaps as a code comment in the first Usage example?

@peterbe
Copy link
Owner

peterbe commented Dec 16, 2024

I updated the tox test to use 3.12, also.
Can you merge in latest master to your branch?

@peterbe peterbe merged commit 9a8390a into peterbe:master Dec 18, 2024
4 checks passed
@peterbe
Copy link
Owner

peterbe commented Dec 18, 2024

Since I don't work on Python projects any more I'm very rusty at PyPI stuff.
But I think https://pypi.org/project/django-cache-memoize/ should have this fix in it.

@EmberCraze
Copy link
Contributor Author

Oh, sorry for the delay. Yeah, this is kind of an expected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants