forked from hyperledger-cacti/cacti
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(quorum/api): contract deploy uses gas estimate
Instead of hardcoding guesses regarding what the CI environment will produce as a gas price for the contract deployment be pro-active, ask for a quote and then offer to spend the quote + a million gas to be on the safe side. This should guarantee that there will be enough gas unless there's a bug in the underlying network (which has happened in the past, quorum had a gas bug where it was asking for more than the maximum possible gas). Also downgraded quorum to v2.2.5 because that is considered stabl while 2.3.0 is a beta release and therefore it is possible that has issues with the gas estimates like previous versions did. Changed the gas upper and lower bounds for blocks through the newly introduced CLI flags of Quorum eth: Consensys/quorum#700 (comment) https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333 https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
- Loading branch information
Showing
4 changed files
with
33 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters