Dev sync ucs map #931

fernandarossi · 2022-11-25T21:14:11Z

Now, the eigenvalues for the synchronous case are computed directly without the need to iterate the rotor speed.

codecov · 2022-11-28T20:14:02Z

Codecov Report

Merging #931 (afb8bea) into master (bb11a77) will increase coverage by 0.75%.
The diff coverage is 32.35%.

❗ Current head afb8bea differs from pull request most recent head a074b7e. Consider uploading reports for the commit a074b7e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
+ Coverage   85.68%   86.43%   +0.75%     
==========================================
  Files          32       31       -1     
  Lines        7368     7323      -45     
==========================================
+ Hits         6313     6330      +17     
+ Misses       1055      993      -62

Impacted Files	Coverage Δ
ross/rotor_assembly.py	`92.15% <32.25%> (-1.03%)`	⬇️
ross/disk_element.py	`97.52% <33.33%> (-0.08%)`	⬇️
ross/__init__.py
ross/stochastic/st_rotor_assembly.py	`93.30% <0.00%> (+0.03%)`	⬆️
ross/defects/rubbing.py	`93.71% <0.00%> (+0.03%)`	⬆️
ross/bearing_seal_element.py	`94.46% <0.00%> (+0.04%)`	⬆️
ross/stochastic/st_results.py	`85.77% <0.00%> (+0.05%)`	⬆️
ross/units.py	`96.61% <0.00%> (+0.05%)`	⬆️
ross/defects/abs_defect.py	`95.74% <0.00%> (+0.09%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb11a77...a074b7e. Read the comment docs.

raphaeltimbo · 2022-11-29T02:25:24Z

Hi @fernandarossi !
This is looking good.
Just to be sure that everything was giving the same results as the old code I added a test for the synchronous case and the expected results that would come from the old code.
The first thing I noticed, but can't exactly point the cause, is that the intersection points (where the support stiffness cross the natural frequency lines) are not the same as in the old code.

To have a better understand of what was happening I ran the test and plotted the results.

This is the result with the old code:

And here with the new code:

If you want to reproduce this here is the code:

import ross as rs

steel = rs.materials.steel

#  Rotor with damping
#  Rotor with 6 shaft elements, 2 disks and 2 bearings with frequency dependent coefficients
i_d = 0
o_d = 0.05
n = 6
L = [0.25 for _ in range(n)]

shaft_elem = [
    rs.ShaftElement(
        l,
        i_d,
        o_d,
        material=steel,
        shear_effects=True,
        rotary_inertia=True,
        gyroscopic=True,
    )
    for l in L
]

disk0 = rs.DiskElement.from_geometry(2, steel, 0.07, 0.05, 0.28)
disk1 = rs.DiskElement.from_geometry(4, steel, 0.07, 0.05, 0.35)

stfx = [1e7, 1.5e7]
stfy = [1e7, 1.5e7]
c = [1e3, 1.5e3]
frequency = [50, 5000]
bearing0 = rs.BearingElement(0, kxx=stfx, kyy=stfy, cxx=c, cyy=c, frequency=frequency)
bearing1 = rs.BearingElement(6, kxx=stfx, kyy=stfy, cxx=c, cyy=c, frequency=frequency)

rotor8 = rs.Rotor(shaft_elem, [disk0, disk1], [bearing0, bearing1])

ucs_results = rotor8.run_ucs(synchronous=True)
ucs_results.plot()

fernandarossi · 2023-01-11T19:24:33Z

Hi @raphaeltimbo. If you run the old and the new code and compare the intersection points, you will observe that:

The first intersection point is the same in both codes;
The second, third, and fourth intersection points are different.

This occurs because when you run the old code, the speed is set to be equal to the first forward frequency. This is valid only for finding the critical speeds corresponding to the first mode. To find the critical speeds corresponding to the second mode, the speed should be set equal to the second forward frequency, and so on. If you do that, the other intersection points will give the same value.

… dev-sync_ucs_map

raphaeltimbo

Hi @fernandarossi!
This is looking good. I have plotted some results and I think we are ready to merge?

I have made only one comment regarding a modification done in the disk_element.py file which I think is not related to this PR. I think we should revert that before merging.

raphaeltimbo · 2023-03-17T09:57:58Z

ross/disk_element.py

-                if np.allclose(self.__dict__[i], other.__dict__[i]):
-                    pass
-                else:
-                    false_number += 1
-
-            except TypeError:
-                if self.__dict__[i] == other.__dict__[i]:
-                    pass
-                else:
-                    false_number += 1
+                self.__dict__[i] == other.__dict__[i]
+            except:
+                false_number += 1


I believe this was modified by mistake, since it is not related to the PR subject.
This would make the following return True when it should be False:

import ross as rs disk0 = rs.DiskElement.from_geometry(2, steel, 0.07, 0.05, 0.28) disk1 = rs.DiskElement.from_geometry(4, steel, 0.07, 0.05, 0.35) disk0 == disk1

I am going to open a specific issue because I've just noticed that we do not have tests to check for inequality.

I changed this part of the code because when I implemented the synchronous case, I had to compare shaft/bearing elements with disk elements. And in these cases, the old code wasn’t working. I will revert the code back to the previous version and make a modification to fix this problem.

marcusfilipesr · 2023-03-28T11:35:13Z

ross/disk_element.py

-                self.__dict__[i] == other.__dict__[i]
-            except:
-                false_number += 1
+        if other.__class__.__name__ == "DiskElement":


Hi @fernandarossi, your lastest commit tests just failed, and I think the reason beghind is this line.

Since you are only comparing with the DiskElement, when building the DiskElement6DoF class it will go directly to the else statement, hence returning False. A possible solution would be:

if "DiskElement" in other.__class__.__name__:

codecov-commenter · 2023-05-15T20:18:48Z

Codecov Report

Attention: Patch coverage is 94.02985% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.06%. Comparing base (f8a8494) to head (8b76b9b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
- Coverage   85.21%   85.06%   -0.16%     
==========================================
  Files          35       35              
  Lines        7583     7613      +30     
==========================================
+ Hits         6462     6476      +14     
- Misses       1121     1137      +16

Files	Coverage Δ
ross/disk_element.py	`100.00% <100.00%> (+0.78%)`	⬆️
ross/rotor_assembly.py	`93.76% <92.85%> (+0.65%)`	⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a8494...8b76b9b. Read the comment docs.

… dev-sync_ucs_map

ross-bott · 2023-08-31T10:32:09Z

Hi there!
I have marked this issue as stale because it has not had activity for 45 days.
Consider the following options:

If the issue refers to a large task, break it in smaller issues that can be solved in
less than 45 days;
Label the issue as wontfix or wontfix for now and close it.

ViniciusTxc3 · 2024-04-10T19:07:15Z

This is a new result with @fernandarossi changes.

@raphaeltimbo This pr ends the issue #573

fernandarossi added 3 commits November 25, 2022 17:34

Including gyroscopic effects in the UCS analysis

059e8e0

Fixing error in comparison between two elements

bab2764

Code formatted with black

afb8bea

Add test to run_ucs synchronous

a1e75ca

fernandarossi and others added 2 commits January 10, 2023 14:57

Merge branch 'ross-rotordynamics:master' into dev-sync_ucs_map

4d366b1

Correction of the UCS map

c6eb943

fernandarossi and others added 2 commits January 11, 2023 19:19

Updated code

a242072

Merge branch 'ross-rotordynamics:master' into dev-sync_ucs_map

c11ef05

marcusfilipesr assigned fernandarossi Feb 3, 2023

fernandarossi and others added 5 commits February 6, 2023 17:32

UCS tests modified

a074b7e

Merge branch 'petrobras:master' into dev-sync_ucs_map

b4c3166

UCS tests update

70c50dd

Merge branch 'dev-sync_ucs_map' of github.com:fernandarossi/ross into…

1bcb8f9

… dev-sync_ucs_map

UCS tests update

2bac55d

raphaeltimbo requested changes Mar 17, 2023

View reviewed changes

fernandarossi and others added 3 commits March 25, 2023 17:41

Merge branch 'petrobras:master' into dev-sync_ucs_map

3fcd2da

Code structure change

5b22e74

Disk element update

8933562

marcusfilipesr reviewed Mar 28, 2023

View reviewed changes

fernandarossi and others added 2 commits March 28, 2023 17:09

Disk element update

0a11c0c

Merge branch 'petrobras:master' into dev-sync_ucs_map

bbef430

raphaeltimbo changed the base branch from master to main May 9, 2023 16:42

fernandarossi closed this May 13, 2023

fernandarossi force-pushed the dev-sync_ucs_map branch from bbef430 to 3a6bafa Compare May 13, 2023 19:23

fernandarossi reopened this May 15, 2023

Merge branch 'dev-sync_ucs_map' of github.com:fernandarossi/ross into…

e002574

… dev-sync_ucs_map

fernandarossi and others added 6 commits May 15, 2023 18:19

Branch restored

0fbdf39

Corrections

e4f0438

Merge branch 'petrobras:main' into dev-sync_ucs_map

799ab32

Merge branch 'main' into dev-sync_ucs_map

b6bc2b6

Merge branch 'petrobras:main' into dev-sync_ucs_map

ebdf759

Merge branch 'petrobras:main' into dev-sync_ucs_map

9a5bb5f

ross-bott added the stale Issues with no activity for a long period label Aug 31, 2023

fernandarossi and others added 4 commits September 2, 2023 12:47

Merge branch 'petrobras:main' into dev-sync_ucs_map

5715135

Merge branch 'petrobras:main' into dev-sync_ucs_map

a5b4812

Merge branch 'main' into dev-sync_ucs_map

f2a7376

Merge branch 'main' into dev-sync_ucs_map

32cffc7

raphaeltimbo mentioned this pull request Mar 14, 2024

Synchronous UCS Map #573

Closed

Test ucs rotor 9 fixed

8b76b9b

raphaeltimbo changed the title ~~WIP: Dev sync ucs map~~ Dev sync ucs map Apr 4, 2024

Merge branch 'main' into dev-sync_ucs_map

a25381e

ViniciusTxc3 requested a review from raphaeltimbo April 10, 2024 19:07

raphaeltimbo approved these changes Apr 11, 2024

View reviewed changes

Merge branch 'main' into dev-sync_ucs_map

e69d577

raphaeltimbo merged commit d9f7716 into petrobras:main Apr 11, 2024
9 checks passed

jguarato mentioned this pull request Apr 15, 2024

Problems with 6 dof model #1043

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev sync ucs map #931

Dev sync ucs map #931

fernandarossi commented Nov 25, 2022

codecov bot commented Nov 28, 2022 •

edited

Loading

raphaeltimbo commented Nov 29, 2022 •

edited

Loading

fernandarossi commented Jan 11, 2023

raphaeltimbo left a comment

raphaeltimbo Mar 17, 2023

fernandarossi Mar 27, 2023

marcusfilipesr Mar 28, 2023

codecov-commenter commented May 15, 2023 •

edited

Loading

ross-bott commented Aug 31, 2023

ViniciusTxc3 commented Apr 10, 2024

Dev sync ucs map #931

Dev sync ucs map #931

Conversation

fernandarossi commented Nov 25, 2022

codecov bot commented Nov 28, 2022 • edited Loading

Codecov Report

raphaeltimbo commented Nov 29, 2022 • edited Loading

fernandarossi commented Jan 11, 2023

raphaeltimbo left a comment

Choose a reason for hiding this comment

raphaeltimbo Mar 17, 2023

Choose a reason for hiding this comment

fernandarossi Mar 27, 2023

Choose a reason for hiding this comment

marcusfilipesr Mar 28, 2023

Choose a reason for hiding this comment

codecov-commenter commented May 15, 2023 • edited Loading

Codecov Report

ross-bott commented Aug 31, 2023

ViniciusTxc3 commented Apr 10, 2024

codecov bot commented Nov 28, 2022 •

edited

Loading

raphaeltimbo commented Nov 29, 2022 •

edited

Loading

codecov-commenter commented May 15, 2023 •

edited

Loading