-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev sync ucs map #931
Merged
Merged
Dev sync ucs map #931
Changes from 16 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
059e8e0
Including gyroscopic effects in the UCS analysis
fernandarossi bab2764
Fixing error in comparison between two elements
fernandarossi afb8bea
Code formatted with black
fernandarossi a1e75ca
Add test to run_ucs synchronous
raphaeltimbo 4d366b1
Merge branch 'ross-rotordynamics:master' into dev-sync_ucs_map
fernandarossi c6eb943
Correction of the UCS map
fernandarossi a242072
Updated code
fernandarossi c11ef05
Merge branch 'ross-rotordynamics:master' into dev-sync_ucs_map
fernandarossi a074b7e
UCS tests modified
fernandarossi b4c3166
Merge branch 'petrobras:master' into dev-sync_ucs_map
fernandarossi 70c50dd
UCS tests update
fernandarossi 1bcb8f9
Merge branch 'dev-sync_ucs_map' of github.com:fernandarossi/ross into…
fernandarossi 2bac55d
UCS tests update
fernandarossi 3fcd2da
Merge branch 'petrobras:master' into dev-sync_ucs_map
fernandarossi 5b22e74
Code structure change
fernandarossi 8933562
Disk element update
fernandarossi 0a11c0c
Disk element update
fernandarossi bbef430
Merge branch 'petrobras:master' into dev-sync_ucs_map
fernandarossi e002574
Merge branch 'dev-sync_ucs_map' of github.com:fernandarossi/ross into…
fernandarossi 0fbdf39
Branch restored
fernandarossi e4f0438
Corrections
fernandarossi 799ab32
Merge branch 'petrobras:main' into dev-sync_ucs_map
fernandarossi b6bc2b6
Merge branch 'main' into dev-sync_ucs_map
ebdf759
Merge branch 'petrobras:main' into dev-sync_ucs_map
fernandarossi 9a5bb5f
Merge branch 'petrobras:main' into dev-sync_ucs_map
fernandarossi 5715135
Merge branch 'petrobras:main' into dev-sync_ucs_map
fernandarossi a5b4812
Merge branch 'petrobras:main' into dev-sync_ucs_map
fernandarossi f2a7376
Merge branch 'main' into dev-sync_ucs_map
32cffc7
Merge branch 'main' into dev-sync_ucs_map
8b76b9b
Test ucs rotor 9 fixed
fernandarossi a25381e
Merge branch 'main' into dev-sync_ucs_map
e69d577
Merge branch 'main' into dev-sync_ucs_map
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fernandarossi, your lastest commit tests just failed, and I think the reason beghind is this line.
Since you are only comparing with the
DiskElement
, when building theDiskElement6DoF
class it will go directly to theelse
statement, hence returningFalse
. A possible solution would be: