Add manylinux2010 to list of supported platforms #778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhoering
force-pushed
the
fix-manylinux2010
branch
from
2c9eb1e
to
42aca42
Compare
wisechengyi
pushed a commit
to pantsbuild/pants
that referenced
this pull request
Oct 21, 2019
### Problem Cryptography==2.8 is a transient dep of requests and pyopenssl. Pip resolves a manylinux2010 whl from pypi which breaks the pants.pex build in the release script. Probably fixed by pex-tool/pex#778 ### Solution pin to last working version ### Result unblocks release
wisechengyi
pushed a commit
to pantsbuild/pants
that referenced
this pull request
Oct 21, 2019
### Problem Cryptography==2.8 is a transient dep of requests and pyopenssl. Pip resolves a manylinux2010 whl from pypi which breaks the pants.pex build in the release script. Probably fixed by pex-tool/pex#778 ### Solution pin to last working version ### Result unblocks release
fhoering
force-pushed
the
fix-manylinux2010
branch
from
42aca42
to
62ec106
Compare
|
Tried with the new version. It correctly pulls manylinux2010 wheels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to to fix #763 as we are also blocked by this issue.
I investigated this problem and in reality it is complicated.
Pex has forked https://github.com/pantsbuild/pex/blob/master/pex/pep425tags.py from setuptools which handles the supported tags. The last pep425tags version from setuptools also handles manylinux2010 & manylinux2014 support but there is currently a PR to replace this by pypa/packaging.tags. So I suppose the real fix would be waiting this to be merged, update vendor/setuptools and then reapply the changes. This looks like a lot of work.
In the meantime (waiting for a proper fix) I suggest just adding manylinux2010 to the list of supported platforms. In reality I think having people publish linux_x86_64 and manylinux1 wheels at the same time already doesn't work very well. So this fix should not be much worse.