Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manylinux2010 to list of supported platforms #778

Closed
wants to merge 2 commits into from
Closed

Add manylinux2010 to list of supported platforms #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd60fc4
Add manylinux2010 to list of supported platforms
fhoering Oct 18, 2019
62ec106
Fix tests
fhoering Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pex/platforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def iter_all_supported():
python_tag, abi_tag, platform_tag = supported
if platform_tag.startswith('linux') and force_manylinux:
yield python_tag, abi_tag, platform_tag.replace('linux', 'manylinux1')
yield python_tag, abi_tag, platform_tag.replace('linux', 'manylinux2010')

return list(OrderedSet(iter_all_supported()))

Expand Down
13 changes: 13 additions & 0 deletions tests/test_platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,22 +107,31 @@ def test_platform_supported_tags_abi3():
expected_tags = [
('cp37', 'cp37m', 'linux_x86_64'),
('cp37', 'cp37m', 'manylinux1_x86_64'),
('cp37', 'cp37m', 'manylinux2010_x86_64'),
('cp37', 'abi3', 'linux_x86_64'),
('cp37', 'abi3', 'manylinux1_x86_64'),
('cp37', 'abi3', 'manylinux2010_x86_64'),
('cp37', 'none', 'linux_x86_64'),
('cp37', 'none', 'manylinux1_x86_64'),
('cp37', 'none', 'manylinux2010_x86_64'),
('cp36', 'abi3', 'linux_x86_64'),
('cp36', 'abi3', 'manylinux1_x86_64'),
('cp36', 'abi3', 'manylinux2010_x86_64'),
('cp35', 'abi3', 'linux_x86_64'),
('cp35', 'abi3', 'manylinux1_x86_64'),
('cp35', 'abi3', 'manylinux2010_x86_64'),
('cp34', 'abi3', 'linux_x86_64'),
('cp34', 'abi3', 'manylinux1_x86_64'),
('cp34', 'abi3', 'manylinux2010_x86_64'),
('cp33', 'abi3', 'linux_x86_64'),
('cp33', 'abi3', 'manylinux1_x86_64'),
('cp33', 'abi3', 'manylinux2010_x86_64'),
('cp32', 'abi3', 'linux_x86_64'),
('cp32', 'abi3', 'manylinux1_x86_64'),
('cp32', 'abi3', 'manylinux2010_x86_64'),
('py3', 'none', 'linux_x86_64'),
('py3', 'none', 'manylinux1_x86_64'),
('py3', 'none', 'manylinux2010_x86_64'),
('cp37', 'none', 'any'),
('cp3', 'none', 'any'),
('py37', 'none', 'any'),
Expand All @@ -135,6 +144,7 @@ def test_platform_supported_tags_abi3():
('py31', 'none', 'any'),
('py30', 'none', 'any'),
]

assert expected_tags == tags


Expand All @@ -146,10 +156,13 @@ def test_platform_supported_tags_no_abi3():
expected_tags = [
('cp37', 'cp37m', 'linux_x86_64'),
('cp37', 'cp37m', 'manylinux1_x86_64'),
('cp37', 'cp37m', 'manylinux2010_x86_64'),
('cp37', 'none', 'linux_x86_64'),
('cp37', 'none', 'manylinux1_x86_64'),
('cp37', 'none', 'manylinux2010_x86_64'),
('py3', 'none', 'linux_x86_64'),
('py3', 'none', 'manylinux1_x86_64'),
('py3', 'none', 'manylinux2010_x86_64'),
('cp37', 'none', 'any'),
('cp3', 'none', 'any'),
('py37', 'none', 'any'),
Expand Down