Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shlex whenever we touch shell-argument-shaped-things directly #1455

Closed
workingjubilee opened this issue Dec 29, 2023 · 3 comments
Closed

Use shlex whenever we touch shell-argument-shaped-things directly #1455

workingjubilee opened this issue Dec 29, 2023 · 3 comments
Labels
build-sys Regarding the "build system" of pgrx which is split between cargo-pgrx, pg-sys, and sql-entity-graph cargo-pgrx

Comments

@workingjubilee
Copy link
Member

in:

we do some things which would be better if we used shlex.
@workingjubilee workingjubilee added cargo-pgrx build-sys Regarding the "build system" of pgrx which is split between cargo-pgrx, pg-sys, and sql-entity-graph labels Dec 29, 2023
@workingjubilee
Copy link
Member Author

Note GHSA-r7qv-8r2h-pg27 which is now patched as of shlex 1.3.0 and is otherwise further proof of why we shouldn't be hand-rolling our own shell-touching code.

@NotGyro NotGyro mentioned this issue Feb 21, 2024
Closed
@NotGyro
Copy link
Contributor

NotGyro commented Feb 21, 2024

It looks like this has been solved in #1468. Let me know if this needs further changes.

@workingjubilee
Copy link
Member Author

Oh, yeah! It seems done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-sys Regarding the "build system" of pgrx which is split between cargo-pgrx, pg-sys, and sql-entity-graph cargo-pgrx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NotGyro @workingjubilee