Handle RUSTFLAGS better #1441
Merged
Handle RUSTFLAGS better #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up PR pgcentralfoundation#1435 as per (pgcentralfoundation#1435 (comment)). What we probably really want is a legit "RUSTFLAGS" parser. I don't feel like writing and testing one and a quick search didn't find anything on crates.io. So splitting on whitespace will have to be Good Enough.
|
I approve my own PR. |
|
This looks fine but we should be using shlex (it is the equivalent of a "legit RUSTFLAGS parser" for our purposes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up PR #1435 as per
(#1435 (comment)).
What we probably really want is a legit "RUSTFLAGS" parser. I don't feel like writing and testing one and a quick search didn't find anything on crates.io. So splitting on whitespace will have to be Good Enough.