Use shlex rather than split_whitespace() #1572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotGyro
force-pushed
the
shlex-for-shell-commands
branch
from
a019c30
to
61856ca
Compare
|
@NotGyro Oh, you shouldn't close and then force-push, that breaks the PR. You'll have to open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential implementation of #1455, in an attempt to resolve #1435 and #1441. As I said in our conversation in the private discord channel, actually implementing this change was very easy but verifying its correctness has been tricky. To my knowledge there's no test that would touch this codepath yet.
After looking over Cargo and Rustc's source and speaking with @workingjubilee, it looks like Cargo reads RUSTFLAGS and passes it to
rustcinvocations, andrustcdoesn't touch RUSTFLAGS directly, so this shouldn't duplicate arguments.