Allow safe u32 -> Oid conversions #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply cast `u32 as i32` and pass it through SPI to do this by other means. While it is an incredibly bad idea to do so, unfortunately that means we cannot rely on the conversion being `unsafe`, as there is no way we would make SPI unsafe. That leaves no persuasive argument for not providing From.
workingjubilee
force-pushed
the
allow-safe-oid-conversions
branch
from
5eb013f
to
45230f3
Compare
|
wait, no it doesn't break. what was I thinking? |
workingjubilee
added a commit
that referenced
this pull request
Dec 5, 2023
A while back Thom discovered this, but we didn't open the PR at the time. Simply cast `u32 as i32` and pass it through SPI to do this by other means. While it is an incredibly bad idea to do so, unfortunately that means we cannot rely on the conversion being `unsafe`, as there is no way we would make SPI unsafe. That leaves no persuasive argument for not providing From.
Merged
workingjubilee
added a commit
that referenced
this pull request
Dec 5, 2023
pgrx v0.11.2 is a minor release which - makes available the storage-related API, thanks to @silver-ymz in #1409 - deprecates the `Oid::from_u32_unchecked` API... because it is actually possible to do via casting in a *query*, which makes it effectively impossible for us to not wind up providing it via some other safe API, since the source is also an easily-Copied type. Thus you can now simply use `From::from` for it. Thanks to @thomcc for this discovery, implemented by @workingjubilee in #1374 As usual, `cargo install cargo-pgrx --version 0.11.2 --locked` and be on your merry way! Thanks everyone!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back Thom discovered this, but we didn't open the PR at the time.
Simply cast
u32 as i32and pass it through SPI to do this by other means. While it is an incredibly bad idea to do so, unfortunately that means we cannot rely on the conversion beingunsafe, as there is no way we would make SPI unsafe. That leaves no persuasive argument for not providing From.