Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow safe u32 -> Oid conversions #1374

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Allow safe u32 -> Oid conversions #1374

merged 2 commits into from
Nov 8, 2023

Commits on Nov 3, 2023

  1. Allow safe Oid conversions 

    Simply cast `u32 as i32` and pass it through SPI to do this by other means.
While it is an incredibly bad idea to do so, unfortunately that means we
cannot rely on the conversion being `unsafe`, as there is no way we would
make SPI unsafe. That leaves no persuasive argument for not providing From.
    @workingjubilee
    workingjubilee committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b6ce27f View commit details
    Browse the repository at this point in the history

  2. Remove unsafeties for Oid conversions

    @workingjubilee
    workingjubilee committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    45230f3 View commit details
    Browse the repository at this point in the history