Add trusted option in the control file #1397
Conversation
| superuser = false | ||
| trusted = false |
There was a problem hiding this comment.
In a case where this was, e.g.
superuser = false
trusted = true
this would do nothing. While Postgres notes this is simply "irrelevant", I think pgrx should error, or at least warn on that case, rather than permitting it to pass by unremarked.
There was a problem hiding this comment.
Thanks. I added another type of error for this case.
| trusted: temp | ||
| .get("trusted") | ||
| .ok_or(ControlFileError::MissingField { field: "trusted" })? | ||
| == &"false", |
There was a problem hiding this comment.
I don't think we should require this parameter to be set. We should simply treat the absent case as equivalent to false, since it de facto is.
There was a problem hiding this comment.
Doing that would also fix the tests.
There was a problem hiding this comment.
Thanks. This field is optional now.
There was a problem hiding this comment.
The CI stuck for more than 2 hours. 😢
There was a problem hiding this comment.
whoops. accidentally out of budget.
|
Thanks! |
`trusted` is supported in postgresql 13 and above. Extensions can add it to control file and also want to support postgresql 12 and below. This PR removes the trusted option in the control file when installing the extension. The default value of `trusted` is false.
return error if superuser is false and trusted is true.
workingjubilee
force-pushed
the
support_trusted_option
branch
from
9580a0d
to
2be29a9
Compare
trustedis supported in postgresql 13 and above. Extensions can add it to the control file and also want to support postgresql 12 and below. This PR removes the trusted option in the control file when installing the extension. The default value oftrustedis false.Related PR in postgresml postgresml/postgresml#810
Options in the control file: https://www.postgresql.org/docs/13/extend-extensions.html#id-1.8.3.20.11