Add trusted option in the control file

cargo-pgrx/src/command/install.rs

@@ -173,6 +173,7 @@ pub(crate) fn install_extension(
             true,
             &package_manifest_path,
             &mut output_tracking,
+            &pg_config,
         )?;
     }
 
@@ -217,6 +218,7 @@ pub(crate) fn install_extension(
             false,
             &package_manifest_path,
             &mut output_tracking,
+            &pg_config,
         )?;
     }
 
@@ -245,6 +247,7 @@ fn copy_file(
     do_filter: bool,
     package_manifest_path: impl AsRef<Path>,
     output_tracking: &mut Vec<PathBuf>,
+    pg_config: &PgConfig,
 ) -> eyre::Result<()> {
     let Some(dest_dir) = dest.parent() else {
         // what fresh hell could ever cause such an error?
@@ -266,7 +269,12 @@ fn copy_file(
         // we want to filter the contents of the file we're to copy
         let input = std::fs::read_to_string(src)
             .wrap_err_with(|| format!("failed to read `{}`", src.display()))?;
-        let input = filter_contents(package_manifest_path, input)?;
+        let mut input = filter_contents(package_manifest_path, input)?;
+
+        if src.display().to_string().ends_with(".control") {
+            input = filter_out_fields_in_control(pg_config, input)?;
+        }
+
         std::fs::write(dest, input).wrap_err_with(|| {
             format!("failed writing `{}` to `{}`", src.display(), dest.display())
         })?;
@@ -401,6 +409,7 @@ fn copy_sql_files(
                         true,
                         &package_manifest_path,
                         output_tracking,
+                        &pg_config,
                     )?;
                 }
             }
@@ -532,3 +541,17 @@ fn filter_contents(manifest_path: impl AsRef<Path>, mut input: String) -> eyre::
 
     Ok(input)
 }
+
+// remove fields in control for versions not supported
+// `trusted`` in only supported in version 13 and above
+fn filter_out_fields_in_control(pg_config: &PgConfig, mut input: String) -> eyre::Result<String> {
+    if pg_config.major_version().unwrap() < 13 {
+        input = input
+            .lines()
+            .filter(|line| !line.starts_with("trusted"))
+            .collect::<Vec<_>>()
+            .join("\n");
+    }
+
+    Ok(input)
+}

cargo-pgrx/src/templates/control

@@ -3,3 +3,4 @@ default_version = '@CARGO_VERSION@'
 module_pathname = '$libdir/{name}'
 relocatable = false
 superuser = true
+trusted = false

pgrx-examples/custom_types/custom_types.control

@@ -3,3 +3,4 @@ default_version = '@CARGO_VERSION@'
 module_pathname = '$libdir/custom_types'
 relocatable = false
 superuser = false
+trusted = false

pgrx-sql-entity-graph/src/control_file.rs

@@ -38,6 +38,7 @@ pub struct ControlFile {
     pub relocatable: bool,
     pub superuser: bool,
     pub schema: Option<String>,
+    pub trusted: bool,
 }
 
 impl ControlFile {
@@ -67,7 +68,7 @@ impl ControlFile {
 
             temp.insert(k, v);
         }
-        Ok(ControlFile {
+        let control_file = ControlFile {
             comment: temp
                 .get("comment")
                 .ok_or(ControlFileError::MissingField { field: "comment" })?
@@ -86,7 +87,15 @@ impl ControlFile {
                 .ok_or(ControlFileError::MissingField { field: "superuser" })?
                 == &"true",
             schema: temp.get("schema").map(|v| v.to_string()),
-        })
+            trusted: if let Some(v) = temp.get("trusted") { v == &"true" } else { false },
+        };
+
+        if !control_file.superuser && control_file.trusted {
+            // `trusted` is irrelevant if `superuser` is false.
+            return Err(ControlFileError::RedundantField { field: "trusted" });
+        }
+
+        Ok(control_file)
     }
 }
 
@@ -100,6 +109,7 @@ impl From<ControlFile> for SqlGraphEntity {
 #[derive(Debug, Clone)]
 pub enum ControlFileError {
     MissingField { field: &'static str },
+    RedundantField { field: &'static str },
 }
 
 impl std::fmt::Display for ControlFileError {
@@ -108,6 +118,9 @@ impl std::fmt::Display for ControlFileError {
             ControlFileError::MissingField { field } => {
                 write!(f, "Missing field in control file! Please add `{field}`.")?;
             }
+            ControlFileError::RedundantField { field } => {
+                write!(f, "Redundant field in control file! Please remove `{field}`.")?;
+            }
         };
         Ok(())
     }