-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PHPUnit 11 #59
Allow PHPUnit 11 #59
Conversation
…ly allow PHPUnit 11
d50e882
to
ad1b652
Compare
Tests seem to fail only due to #60 [EDIT] |
@Jean85 that's expected: the PR in prophecy has been merged, but there has not been a new release yet. So jobs running with stable dependencies cannot install a version of Prophecy supporting PHPUnit 11 yet (that's the whole point of having a job running with dev deps btw: testing those things before the release instead of only after it). |
Right right, I figured out the same while you were replying. So, it's seems to work, apart from the deprecation that I already reported in #60. |
For the deprecation, let's wait for the answer of Sebastian about the proper way to solve our case (see my comment in the issue and the corresponding issue opened in the phpunit issue tracker) |
@stof I've introduced the attributes, and fixed the build with a dedicated, migrated configuration. |
e426d79
to
ae95f1a
Compare
Thank you for this PR. Do you have a plan to release a new version of the package with the support for PHPUnit 11? |
This PR is the only code change needed to run with PHPUnit 11, but it also requires phpspec/prophecy#616, as proved by #58.