-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow PHPUnit 11 (WIP) #229
feat: allow PHPUnit 11 (WIP) #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunately not enough, since Prophecy is stopping the upgrade too.
We need two additional, external PRs for that, one in phpspec/prophecy-phpunit
(to allow PHPUnit 11), the second in phpspec/prophecy
(to allow sebastian/comparator
6).
I'll try to do that ASAP, but I starting to think that I may migrate toward PHPUnit's mocks...
I did a look at this repos, and there is maybe more :( |
If you make this decision I'd be happy to help. I already did it in PHP CS Fixer repo. |
Ok, I've filed phpspec/prophecy#616 and phpspec/prophecy-phpunit#59, but we need both of them to work here. I'll try to commit the requirement for phpspec/prophecy-phpunit#58 to pull this off.
Thanks! That would be helpful: the only doubt that I have is that in that way, I would be bound to PHPUnit breaking changes, and I do not know if that would be better or worse compared to the issues I'm having with Prophecy. |
Closing in favor of #230, GitHub Actions are not allowing secrets to be used when the PR comes from a fork. |
`composer require "phpunit/phpunit:11.0.1" --dry-run``