Fix empty regex and empty alternation parse #3507
Open
+142
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
fix_empty_alternation
branch
2 times, most recently
from
b473d7f
to
bcd469c
Compare
staabm
reviewed
Sep 27, 2024
mvorisek
force-pushed
the
fix_empty_alternation
branch
from
bcd469c
to
d79f280
Compare
|
This pull request has been marked as ready for review. |
mvorisek
force-pushed
the
fix_empty_alternation
branch
2 times, most recently
from
9f87f5a
to
4c61b1f
Compare
|
Do empty alternations or empty capturing groups have real world relevance? I don't think I have ever seen a regex using it..? |
|
They definitely do, |
ondrejmirtes
requested changes
Oct 6, 2024
mvorisek
force-pushed
the
fix_empty_alternation
branch
from
4c61b1f
to
7230e5d
Compare
mvorisek
force-pushed
the
fix_empty_alternation
branch
2 times, most recently
from
84a8ecf
to
fa1f464
Compare
mvorisek
force-pushed
the
fix_empty_alternation
branch
from
afac899
to
d08e625
Compare
|
@staabm can I have your review here? |
mvorisek
force-pushed
the
fix_empty_alternation
branch
from
d08e625
to
3c9c813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix phpstan/phpstan#11762