Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pnpm lockfile v9 #1395

Closed
1 of 2 tasks
kylewillmon opened this issue Apr 16, 2024 · 1 comment · Fixed by #1414
Closed
1 of 2 tasks

Support pnpm lockfile v9 #1395

kylewillmon opened this issue Apr 16, 2024 · 1 comment · Fixed by #1414
Assignees
@cd-work
Labels
enhancement New feature or request

Comments

@kylewillmon
Copy link
Contributor

kylewillmon commented Apr 16, 2024 •
edited by maxrake
Loading

The recent release of pnpm v9.0.0 includes a new lockfile version (v9). The CLI currently only test our parser against v6. We should now add support for v9

Tasks

  • Add a v9 lockfile to our test suite
  • Make any changes as necessary to support both v6 and v9 versions
@kylewillmon kylewillmon added the enhancement New feature or request label Apr 16, 2024
@cd-work cd-work self-assigned this May 7, 2024
@cd-work
Copy link
Contributor

cd-work commented May 7, 2024

Turns out version 6 and 9 are more different than initially assumed. We'll need to adjust our parser.

cd-work added a commit that referenced this issue May 7, 2024
@cd-work
Add support for PNPM v9
d82310d 
Closes #1395.
@cd-work cd-work mentioned this issue May 7, 2024
Merged
cd-work added a commit that referenced this issue May 8, 2024
@cd-work
Add support for PNPM v9 (#1414)
7305a6a 
Closes #1395.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cd-work cd-work

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for PNPM v9 phylum-dev/cli
2 participants
@kylewillmon @cd-work