Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PNPM v9 #1414

Merged
merged 2 commits into from
May 8, 2024
Merged

Add support for PNPM v9 #1414

merged 2 commits into from
May 8, 2024

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented May 7, 2024

Closes #1395.

@cd-work cd-work requested a review from a team as a code owner May 7, 2024 21:37
@cd-work cd-work requested a review from maxrake May 7, 2024 21:37
maxrake
maxrake requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was reviewed and the changes were tested locally with some real-world pnpm v9 lockfiles. It all worked as intended. The only requested change is to add a CHANGELOG entry.

@cd-work cd-work requested a review from maxrake May 8, 2024 17:27
maxrake
maxrake approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cd-work cd-work merged commit 7305a6a into main May 8, 2024
14 checks passed
@cd-work cd-work deleted the pnpm_v9 branch May 8, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrake maxrake maxrake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pnpm lockfile v9
2 participants
@cd-work @maxrake