Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing pnpm-lock.yaml can result in incorrect versions #1538

Closed
furi0us333 opened this issue Nov 22, 2024 · 0 comments · Fixed by #1539
Closed

Parsing pnpm-lock.yaml can result in incorrect versions #1538

furi0us333 opened this issue Nov 22, 2024 · 0 comments · Fixed by #1539
Assignees
@cd-work
Labels
bug Something isn't working

Comments

@furi0us333
Copy link
Contributor

Overview

The parsing of pnpm lockfiles can sometimes result in incorrect versions.

How To Reproduce

Steps to reproduce this behavior:
I will provide a sample file in slack.

Expected Behavior

Correctly parse pnpm lockfiles.

Additional Context

Entries in the lockfile like this seem to be the cause:
image

The parser returns this:
image

But the correct version is just 1.2.2
image
@furi0us333 furi0us333 added bug Something isn't working needs triage Needs to be reviewed or assigned labels Nov 22, 2024
@cd-work cd-work self-assigned this Nov 22, 2024
cd-work added a commit that referenced this issue Nov 22, 2024
@cd-work
Fix PNPM v5 version parsing
6ae64a8 
This fixes an issue with the lockfile parser of PNPM v5 lockfiles which
would incorrectly include metadata in the package version.

Closes #1538.
cd-work added a commit that referenced this issue Nov 22, 2024
@cd-work
Fix PNPM v5 version parsing
4c4246a 
This fixes an issue with the lockfile parser of PNPM v5 lockfiles which
would incorrectly include metadata in the package version.

Closes #1538.
@cd-work cd-work mentioned this issue Nov 22, 2024
Merged
@maxrake maxrake removed the needs triage Needs to be reviewed or assigned label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cd-work cd-work

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PNPM v5 version parsing phylum-dev/cli
3 participants
@maxrake @furi0us333 @cd-work