Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PNPM v5 version parsing #1539

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix PNPM v5 version parsing #1539

merged 1 commit into from
Nov 22, 2024

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Nov 22, 2024

This fixes an issue with the lockfile parser of PNPM v5 lockfiles which would incorrectly include metadata in the package version.

Closes #1538.

This fixes an issue with the lockfile parser of PNPM v5 lockfiles which
would incorrectly include metadata in the package version.

Closes #1538.
@cd-work cd-work self-assigned this Nov 22, 2024
@cd-work cd-work requested a review from a team as a code owner November 22, 2024 20:52
@cd-work cd-work requested a review from maxrake November 22, 2024 20:52
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but approving now since the changes here address the linked issue.

lockfile/src/javascript.rs Show resolved Hide resolved
@cd-work cd-work merged commit ff50531 into main Nov 22, 2024
17 checks passed
@cd-work cd-work deleted the pnpm_v5_versions branch November 22, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing pnpm-lock.yaml can result in incorrect versions
2 participants