Add org support for init/project/analyze/history #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch uses the `Config::org` function to add support for org support in all subcommands that were still missing org support. Generally when an org is linked, the org mode is always preferred. Only in scenarios where no group is present at all, like `phylum project delete <NAME>`, the personal projects will be used instead. Since this could potentially lead to a lot of confusion with the project management subcommands, all project subcommands have been changed to print projects in a fixed format that lists the corresponding org and group: ``` ✅ Successfully deleted project cli (org: phylum, group: org-group) ``` ``` ✅ Successfully deleted project demo (org: -, group: -) ``` Closes #1482.
This introduces a new type which allows providing static API guarantees for org and group combinations.
matt-phylum
reviewed
Sep 9, 2024
matt-phylum
previously approved these changes
Sep 10, 2024
matt-phylum
approved these changes
Sep 10, 2024
maxrake
added a commit
that referenced
this pull request
Nov 6, 2024
This change fixes an oversight from when org support was first added to the extension API. The new `organization` parameters were added to `extensions/phylum.d.ts` but not exposed for consumers in `cli/js/api.js`. [See commit `f890fea`](f890fea) or #1490 Additionally, a review of the default and community extensions revealed only one use of one of these changed API calls: * `snyk-import`, for `createProject` * https://github.com/phylum-dev/community-extensions/blob/4c878e27930a9cdd332d65b066e514b778ef9a9a/snyk-import/main.ts#L69
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses the
Config::orgfunction to add support for orgsupport in all subcommands that were still missing org support.
Generally when an org is linked, the org mode is always preferred. Only
in scenarios where no group is present at all, like
phylum project delete <NAME>, the personal projects will be used instead.Since this could potentially lead to a lot of confusion with the project
management subcommands, all project subcommands have been changed to
print projects in a fixed format that lists the corresponding org and
group:
Closes #1482.