Add organization parameters to Phylum object
#1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an oversight from when org support was first added to the extension API. The new `organization` parameters were added to `extensions/phylum.d.ts` but not exposed for consumers in `cli/js/api.js`. [See commit `f890fea`](f890fea) or #1490 Additionally, a review of the default and community extensions revealed only one use of one of these changed API calls: * `snyk-import`, for `createProject` * https://github.com/phylum-dev/community-extensions/blob/4c878e27930a9cdd332d65b066e514b778ef9a9a/snyk-import/main.ts#L69
cd-work
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change fixes an oversight from when org support was first added to the extension API. The new
organizationparameters were added toextensions/phylum.d.tsbut not exposed for consumers incli/js/api.js.See commit
f890feaor PR #1490Testing
The changes from this PR were confirmed to work by using them in the
ciextension forphylum-ci(after updating it to account for organizations).Additional Information
A review of the default and community extensions revealed only one use of one of these changed API calls:
snyk-import, forcreateProjectsnyk-importto account for organizations community-extensions#46