Move login form to a new page #2290

rdwebdesign · 2022-08-09T22:01:33Z

Please make sure you

Base your code and PRs against the repositories developmental branch.
Sign Off all commits as we enforce the DCO for all contributions

What does this PR aim to accomplish?:

This PR creates a new login page, with its own layout.

How does this PR accomplish the above?:

Removing the old login page and creating a new one.

What documentation changes (if any) are needed to support this PR?:

Maybe a few screenshots.

By submitting this pull request, I confirm the following:

I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code and I have tested my changes.
I am willing to help maintain this change if there are issues with it later.
It is compatible with the EUPL 1.2 license
I have squashed any insignificant commits. (git rebase)

I have read the above and my PR is ready for review. Check this box to confirm

yubiuser

I assume scripts/php/loginpage.phpcan go as well?

yubiuser · 2022-08-10T19:52:49Z

login.php

+
+        <div class="card">
+            <div class="card-body login-card-body">
+                <p class="login-box-msg">Sign in to start your session</p>


Do we need this text at all? If so, maybe

Suggested change

<p class="login-box-msg">Sign in to start your session</p>

<p class="login-box-msg">Sign in to access Pi-hole's dashboard</p>

I don't have a strong opinion about this, but I would follow one of this ideas:

remove the text;

use "Sign in to access the dashboard"
I don't think we need to use "Pi-hole" again. The name and logo are is already above this line.

Then I would remove the text. What else should happen after you clicked "log in" on a login page other than being logged in?

scripts/pi-hole/php/header.php

yubiuser · 2022-08-10T20:01:08Z

scripts/pi-hole/php/header.php

    <link rel="stylesheet" href="style/vendor/bootstrap/css/bootstrap.min.css?v=<?php echo $cacheVer; ?>">
+<?php if ($auth) { ?>


Do you want to leave this here or move it to header_authenticated.php? It won't be used on the login page.

Yes.
This file (header.php) is included in both cases.

This if is needed to only use this block when authenticated.

Yeah this is exactly my point. header.php is used for login.php and header_authenthicated.php. But this part is never used on the login.php because $auth is not set when the login is shown. Therefore it makes sense to me to move it to header_authenticated and remove the if clause.

No.

header_authenticated.php is used ONLY for authenticated pages.
header.php is used in both cases (it is included in header_authenticated.php).

I'm trying to put all <head> stuff in one place to make it easy to maintain.
I'm also trying to group all <scripts> and all <link> tags together in just one place.

We can remove the ifs and separate these tags in 2 files, but I think its more logical to put them together.

scripts/pi-hole/php/header.php

login.php

Bumps [actions-ecosystem/action-add-labels](https://github.com/actions-ecosystem/action-add-labels) from 1.1.0 to 1.1.3. - [Release notes](https://github.com/actions-ecosystem/action-add-labels/releases) - [Commits](actions-ecosystem/action-add-labels@v1.1.0...v1.1.3) --- updated-dependencies: - dependency-name: actions-ecosystem/action-add-labels dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: DL6ER <dl6er@dl6er.de>

Co-authored-by: yubiuser <ckoenig@posteo.de> Signed-off-by: DL6ER <DL6ER@users.noreply.github.com>

…quire* Signed-off-by: DL6ER <dl6er@dl6er.de>

Signed-off-by: DL6ER <dl6er@dl6er.de>

…xer to Symfony Signed-off-by: DL6ER <dl6er@dl6er.de>

Signed-off-by: DL6ER <dl6er@dl6er.de>

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

- Remove unnecessary "Sign in to start" text; - Adjust LCARS colors: login error message; - Fix javascript error in `footer.js`. Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

rdwebdesign · 2022-08-12T20:34:04Z

Superseded by #2294

rdwebdesign mentioned this pull request Aug 9, 2022

Move login form to a new login screen. #2281

Closed

1 task

yubiuser reviewed Aug 10, 2022

View reviewed changes

rdwebdesign requested a review from yubiuser August 10, 2022 18:49

yubiuser reviewed Aug 10, 2022

View reviewed changes

yubiuser reviewed Aug 12, 2022

View reviewed changes

login.php Show resolved Hide resolved

yubiuser mentioned this pull request Aug 12, 2022

Remove top navbar menu #2292

Closed

1 task

dependabot bot and others added 15 commits August 12, 2022 16:59

Add PHP-CS-Fixer Workflow

ed22d84

Signed-off-by: DL6ER <dl6er@dl6er.de>

Run PHP-CS-Fixer on all files

44bec59

Signed-off-by: DL6ER <dl6er@dl6er.de>

Fix remaining styling change

f1feffe

Signed-off-by: DL6ER <dl6er@dl6er.de>

Update .php-cs-fixer.dist.php

31711fe

Co-authored-by: yubiuser <ckoenig@posteo.de> Signed-off-by: DL6ER <DL6ER@users.noreply.github.com>

Update .github/workflows/php-cs-fixer.yml

3470c1d

Co-authored-by: yubiuser <ckoenig@posteo.de> Signed-off-by: DL6ER <DL6ER@users.noreply.github.com>

Explicitly set blank_line_before_statement to exclude include* and re…

174e8a8

…quire* Signed-off-by: DL6ER <dl6er@dl6er.de>

Switch to style Symfony

d53159d

Signed-off-by: DL6ER <dl6er@dl6er.de>

Fix unecessary string concat added during the conversion from PhpCsFi…

6206a9a

…xer to Symfony Signed-off-by: DL6ER <dl6er@dl6er.de>

Add setLineEnding(PHP_EOL)

c5e4af7

Signed-off-by: DL6ER <dl6er@dl6er.de>

Disable Yoda style

655d343

Signed-off-by: DL6ER <dl6er@dl6er.de>

Move login form to a new page

40a1efc

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

Rename header.php to header_authenticated.php

a90b0ab

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

Rename common_header.php to header.php

3309644

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

Fixes for the new login

8a94dfd

- Remove unnecessary "Sign in to start" text; - Adjust LCARS colors: login error message; - Fix javascript error in `footer.js`. Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

rdwebdesign force-pushed the newloginpage2 branch from b377acf to 8a94dfd Compare August 12, 2022 20:09

rdwebdesign closed this Aug 12, 2022

rdwebdesign deleted the newloginpage2 branch August 12, 2022 20:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move login form to a new page #2290

Move login form to a new page #2290

rdwebdesign commented Aug 9, 2022

yubiuser left a comment

yubiuser Aug 10, 2022

rdwebdesign Aug 10, 2022

yubiuser Aug 11, 2022

rdwebdesign Aug 11, 2022

yubiuser Aug 10, 2022

rdwebdesign Aug 10, 2022 •

edited

Loading

yubiuser Aug 11, 2022 •

edited

Loading

rdwebdesign Aug 11, 2022

rdwebdesign Aug 11, 2022

rdwebdesign commented Aug 12, 2022

	<p class="login-box-msg">Sign in to start your session</p>
	<p class="login-box-msg">Sign in to access Pi-hole's dashboard</p>

		<link rel="stylesheet" href="style/vendor/bootstrap/css/bootstrap.min.css?v=<?php echo $cacheVer; ?>">
		<?php if ($auth) { ?>

Move login form to a new page #2290

Move login form to a new page #2290

Conversation

rdwebdesign commented Aug 9, 2022

yubiuser left a comment

Choose a reason for hiding this comment

yubiuser Aug 10, 2022

Choose a reason for hiding this comment

rdwebdesign Aug 10, 2022

Choose a reason for hiding this comment

yubiuser Aug 11, 2022

Choose a reason for hiding this comment

rdwebdesign Aug 11, 2022

Choose a reason for hiding this comment

yubiuser Aug 10, 2022

Choose a reason for hiding this comment

rdwebdesign Aug 10, 2022 • edited Loading

Choose a reason for hiding this comment

yubiuser Aug 11, 2022 • edited Loading

Choose a reason for hiding this comment

rdwebdesign Aug 11, 2022

Choose a reason for hiding this comment

rdwebdesign Aug 11, 2022

Choose a reason for hiding this comment

rdwebdesign commented Aug 12, 2022

rdwebdesign Aug 10, 2022 •

edited

Loading

yubiuser Aug 11, 2022 •

edited

Loading