Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top navbar menu #2292

Closed
wants to merge 6 commits into from
Closed

Remove top navbar menu #2292

wants to merge 6 commits into from

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 12, 2022

What does this PR aim to accomplish?:

Removes the top navbar menu.

Bildschirmfoto zu 2022-08-12 14-50-26


The menu does not offer a lot of information and was kind of "hidden".
The links to Github and pi-hole.net have been moved to the side bar, Donate was already there (and in the footer).
Now the session timer is missing, but the default session time is 24 hours minutes (see comments below) to there is no need to be constantly aware of the remaining time. And the link to the latest release has been removed, but it might be better to link to the discourse announcements instead of the core releases only anyway.

Additionally, I moved to logout button to the upper right corner of the top navbar. This is a location where usually logout buttons are placed.

Bildschirmfoto zu 2022-08-12 14-46-19
Bildschirmfoto zu 2022-08-12 14-46-24

Best to be merged after #2290


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser added Discussion PR: Approval Required Open Pull Request, needs approval labels Aug 12, 2022
@yubiuser yubiuser requested a review from a team August 12, 2022 12:55
Signed-off-by: Christian König <ckoenig@posteo.de>
@DL6ER
Copy link
Member

DL6ER commented Aug 12, 2022

but the default session time is 24 hours to there is no need to be constantly aware of the remaining time

This is interesting, this has initially been designed for 5 minutes. When staying on the dashboard, the API calls constantly bumped this time so you were never kicked out, but a session time of 24 hours seems pretty useless.

@rdwebdesign
Copy link
Member

but the default session time is 24 hours to there is no need to be constantly aware of the remaining time

I think it is configured to 24 minutes.

If you access any page (except the dashboard), you will see the countdown. In the dashboard page the counter is constantly restarted and always shows 23 minutes and 59 seconds.

Anyway, this counter is useless.

@yubiuser
Copy link
Member Author

@rdwebdesign
Copy link
Member

rdwebdesign commented Aug 12, 2022

My original suggestion was to turn this area into a useful menu, to reduce the main menu, like this:
Menu_suggestion

Note:
I think the counter should be removed too.

@yubiuser
Copy link
Member Author

If we keep the menu, we should use an other symbol to indicate that there is a menu. In my opinion the current symbol+logo or the proposed hostname do not indicate strong enough that a menu is hidden there.

@rdwebdesign
Copy link
Member

I agree.

If we decide to keep the menu, we should use the "hamburger" menu icon
image

And use different icons for collapse/restore the menu:
image
image

@dschaper
Copy link
Member

Please remove Designed for Raspberry Pi... They've come after us more than once for using their trademarked names.

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

I changed to hamburger menu icon to arrows which will change direction on click

@yubiuser yubiuser force-pushed the remove_top_menu branch 2 times, most recently from d2ca833 to 063d8d0 Compare August 12, 2022 21:30
Signed-off-by: Christian König <ckoenig@posteo.de>
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

Superseded by #2298

@yubiuser yubiuser closed this Aug 16, 2022
@yubiuser yubiuser deleted the remove_top_menu branch August 16, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants