-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove top navbar menu #2292
Remove top navbar menu #2292
Conversation
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
0e91c39
to
a7856a1
Compare
This is interesting, this has initially been designed for 5 minutes. When staying on the dashboard, the API calls constantly bumped this time so you were never kicked out, but a session time of 24 hours seems pretty useless. |
I think it is configured to 24 minutes. If you access any page (except the dashboard), you will see the countdown. In the dashboard page the counter is constantly restarted and always shows 23 minutes and 59 seconds. Anyway, this counter is useless. |
Sorry, 24 minutes is right. It's php default. https://www.php.net/manual/en/session.configuration.php#ini.session.gc-maxlifetime It was always like this: https://github.com/pi-hole/AdminLTE/pull/197/files |
If we keep the menu, we should use an other symbol to indicate that there is a menu. In my opinion the current symbol+logo or the proposed hostname do not indicate strong enough that a menu is hidden there. |
Please remove |
Signed-off-by: Christian König <ckoenig@posteo.de>
I changed to hamburger menu icon to arrows which will change direction on click |
d2ca833
to
063d8d0
Compare
Signed-off-by: Christian König <ckoenig@posteo.de>
063d8d0
to
b1d35e1
Compare
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br> Signed-off-by: Christian König <ckoenig@posteo.de>
Superseded by #2298 |
What does this PR aim to accomplish?:
Removes the top navbar menu.
The menu does not offer a lot of information and was kind of "hidden".
The links to Github and
pi-hole.net
have been moved to the side bar, Donate was already there (and in the footer).Now the session timer is missing, but the default session time is 24
hoursminutes (see comments below) to there is no need to be constantly aware of the remaining time. And the link to the latest release has been removed, but it might be better to link to the discourse announcements instead of thecore
releases only anyway.Additionally, I moved to logout button to the upper right corner of the top navbar. This is a location where usually logout buttons are placed.
Best to be merged after #2290
By submitting this pull request, I confirm the following:
git rebase
)