Improve top right menu and sidebar #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
rdwebdesign
force-pushed
the
test_topmenu
branch
3 times, most recently
from
7f2d292 to
c6ee623
Compare
rdwebdesign
force-pushed
the
test_topmenu
branch
2 times, most recently
from
76237f2 to
b03fdda
Compare
rdwebdesign
force-pushed
the
test_topmenu
branch
2 times, most recently
from
fc72353 to
0df817c
Compare
yubiuser
previously approved these changes
Aug 18, 2022
rdwebdesign
force-pushed
the
test_topmenu
branch
2 times, most recently
from
ab9dcbf to
3353873
Compare
- fix broken visual after initial changes; - remove donate button from topmenu; - re-add donate button to the sidebar and add hover color; - remove "Ph" when collapsed; - add icon and background to topmenu button; - hide main menu headers (using lines as separators); - reorder the main menu; - adjust each theme to the new visual (CSS and HTML tweaks). - new menu colors for LCARS theme Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
rdwebdesign
force-pushed
the
test_topmenu
branch
from
3353873 to
f1698c3
Compare
|
Button colors changed as requested. |
rdwebdesign
requested review from
dschaper and
yubiuser
and removed request for
dschaper
yubiuser
previously approved these changes
Aug 19, 2022
dschaper
previously approved these changes
Aug 19, 2022
rdwebdesign
force-pushed
the
test_topmenu
branch
from
f1698c3 to
26c472c
Compare
yubiuser
previously approved these changes
Aug 19, 2022
- keep using inline SVG to allow color change via CSS; - Reuse the SVG icon in all instances, using SVG symbol; - Simplify/reduce inline SVG code; Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
rdwebdesign
force-pushed
the
test_topmenu
branch
from
26c472c to
5b4f8d8
Compare
yubiuser
approved these changes
Aug 19, 2022
dschaper
approved these changes
Aug 19, 2022
yubiuser
added
the
PR: Approved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
After the discussion about remove or improve the top menu, we decided to improve it and make it more useful.
We also decided to make a few changes to topbar and sidebar.
How does this PR accomplish the above?:
Top menu (far top right):
Logoutbutton was moved here;Pi-hole websiteDocumentation;Pi-hole Forum;GithubandReleases;Top bar:
logo+Pi-holetext replaced by a "hamburger" icon (3 bars icon);Main Menu (sidebar):
What documentation changes (if any) are needed to support this PR?:
none
By submitting this pull request, I confirm the following:
git rebase)