Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to avoid "Undefined Variable" warnings #2316

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Add test to avoid "Undefined Variable" warnings #2316

merged 1 commit into from
Aug 28, 2022

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?:

Fix #2315

How does this PR accomplish the above?:

Adding a test to assure the variables are set before using them.

What documentation changes (if any) are needed to support this PR?:

none

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign
Add test to avoid "Undefined Variable" warnings
ae74023 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign force-pushed the fix/footer_update_nondocker branch from c5b47b8 to ae74023 Compare August 28, 2022 19:38
@rdwebdesign rdwebdesign requested review from yubiuser and a team August 28, 2022 19:40
@yubiuser yubiuser linked an issue Aug 28, 2022 that may be closed by this pull request
PHP Notices spaming the log ("Undefined index" and "Undefined variable"). #2315
Closed
@rdwebdesign rdwebdesign merged commit 5827d96 into devel Aug 28, 2022
@rdwebdesign rdwebdesign deleted the fix/footer_update_nondocker branch August 28, 2022 21:22
@rdwebdesign rdwebdesign mentioned this pull request Aug 29, 2022
Merged
1 task
PromoFaux added a commit that referenced this pull request Sep 2, 2022
@PromoFaux
Fix PHP warnings in docker (Complement of #2316) (#2318)
9c01f7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP Notices spaming the log ("Undefined index" and "Undefined variable").
2 participants
@rdwebdesign @yubiuser