Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP warnings in docker (Complement of #2316) #2318

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?:

Fix "undefined variable" PHP warnings in docker.
#2316 fixed the warnings for normal installs, but created warnings in docker.

How does this PR accomplish the above?:

Always adding values for the variables.

What documentation changes (if any) are needed to support this PR?:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

- other undefined vars are still spamming the log

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign requested a review from a team August 29, 2022 21:28
@PromoFaux
Copy link
Member

I think now with this one needs to add the check as I was with my PR before else the individual component updates will show on a docker container (which is undesirable!)

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign
Copy link
Member Author

I fixed it. Now it should work as expected.

@rdwebdesign rdwebdesign requested a review from PromoFaux August 30, 2022 19:27
@PromoFaux PromoFaux self-assigned this Aug 31, 2022
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@PromoFaux PromoFaux merged commit 9c01f7b into devel Sep 2, 2022
@PromoFaux PromoFaux deleted the fix/footer_update_nondocker2 branch September 2, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants