Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of value_types and error_types with references in all sender adaptors #284

Closed
12 tasks done
msimberg opened this issue Jun 30, 2022 · 4 comments · Fixed by #320, #285 or #484
Closed
12 tasks done

Fix handling of value_types and error_types with references in all sender adaptors #284

msimberg opened this issue Jun 30, 2022 · 4 comments · Fixed by #320, #285 or #484
Assignees
@aurianer
Labels
effort: 2 A few hours of work. priority: high This is essential functionality or a serious bug. Not addressing this blocks progress. type: bug
Milestone
0.10.0

Comments

@msimberg
Copy link
Contributor

msimberg commented Jun 30, 2022 •
edited
Loading

See #282 for details.

These need to be checked and fixed if necessary:
@msimberg msimberg added effort: 2 A few hours of work. priority: medium This should be done sooner or later. type: bug labels Jun 30, 2022
@msimberg msimberg moved this to Backlog in pika planning board Jun 30, 2022
@msimberg msimberg mentioned this issue Jul 1, 2022
Merged
1 task
@msimberg msimberg added this to the 0.7.0 milestone Jul 5, 2022
@msimberg msimberg added priority: high This is essential functionality or a serious bug. Not addressing this blocks progress. and removed priority: medium This should be done sooner or later. labels Jul 7, 2022
@msimberg msimberg mentioned this issue Jul 8, 2022
Merged
@aurianer aurianer mentioned this issue Jul 13, 2022
Merged
@aurianer aurianer changed the title Fix handling of value_types with references in all sender adaptors Fix handling of value_types and error_types with references in all sender adaptors Jul 13, 2022
@bors bors bot closed this as completed in a2bf280 Jul 14, 2022
Repository owner moved this from Backlog to Done in pika planning board Jul 14, 2022
@msimberg msimberg reopened this Jul 14, 2022
Repository owner moved this from Done to Todo in pika planning board Jul 14, 2022
@aurianer
Copy link
Contributor

"partially" in resolving an issue is not taken into account with bors anymore?

@msimberg
Copy link
Contributor Author

It never did, and bors doesn't do anything about closing issues. That's all GitHub.

@aurianer
Copy link
Contributor

Yes indeed as you pointed out I switched the position of partially and fixed, so it doesn't work in this order

@msimberg
Copy link
Contributor Author

For reference, this is the syntax used for automatically closing issues: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword.

bors bot added a commit that referenced this issue Jul 19, 2022
@bors @msimberg
Merge #285
5539b95 
285: Enable tests for P2300 reference implementation split r=msimberg a=msimberg

We already had it enabled in the header, but I had forgotten to remove the ifdefs in the test file. This also fixes part of #284 for `sync_wait` and `split` since those were broken after updating the test.

To do:
- [x] Add tests for the error channel with `const_reference_error_sender` from #307.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@msimberg msimberg linked a pull request Jul 19, 2022 that will close this issue
Enable tests for P2300 reference implementation split #285
Merged
1 task
@aurianer aurianer mentioned this issue Jul 28, 2022
Merged
@aurianer aurianer modified the milestones: 0.7.0, 0.8.0 Aug 2, 2022
bors bot added a commit that referenced this issue Aug 4, 2022
@bors @aurianer
Merge #338
f92849c 
338: Handle reference error types in `ensure_started` and `let_error` r=msimberg a=aurianer

Fixes partially #284

Co-authored-by: Auriane R <aurianer@cscs.ch>
bors bot added a commit that referenced this issue Aug 4, 2022
@bors @aurianer
Merge #338
876eb35 
338: Handle reference error types in `ensure_started` and `let_error` r=msimberg a=aurianer

Fixes partially #284

Co-authored-by: Auriane R <aurianer@cscs.ch>
@msimberg msimberg mentioned this issue Aug 11, 2022
Merged
@msimberg msimberg moved this from Todo to In Progress in pika planning board Aug 11, 2022
@msimberg msimberg removed their assignment Aug 11, 2022
bors bot added a commit that referenced this issue Aug 16, 2022
@bors @msimberg
Merge #371 #379
f7c3d46 
371: Fix a few more reference type sender issues r=aurianer a=msimberg

Part of #284.

- Slightly changes the test for `bulk`
- Adds a `const_reference_sender` test for `let_error`
- Enables the `const_reference_error_sender` test for `let_error` with the P2300 reference implementation

Also note that I've listed what still needs to be checked/updated in #284.

379: Clean up filesystem module r=aurianer a=msimberg

Part of #16. Not much to do here...

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
bors bot added a commit that referenced this issue Aug 16, 2022
@bors @msimberg
Merge #371
8e96b5b 
371: Fix a few more reference type sender issues r=aurianer a=msimberg

Part of #284.

- Slightly changes the test for `bulk`
- Adds a `const_reference_sender` test for `let_error`
- Enables the `const_reference_error_sender` test for `let_error` with the P2300 reference implementation

Also note that I've listed what still needs to be checked/updated in #284.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@msimberg msimberg modified the milestones: 0.8.0, 0.9.0 Sep 7, 2022
@aurianer aurianer modified the milestones: 0.9.0, 0.10.0 Oct 5, 2022
This was referenced Oct 5, 2022
Merged
Merged
bors bot added a commit that referenced this issue Oct 10, 2022
@bors @aurianer
Merge #472
3c71042 
472: Add const reference handling test for `let_value` r=msimberg a=aurianer

Add reference handling test for `let_value` sender.
Fix partially #284

Co-authored-by: Auriane R <aurianer@cscs.ch>
Co-authored-by: aurianer <aurianer@cscs.ch>
bors bot added a commit that referenced this issue Oct 10, 2022
@bors @aurianer
Merge #472
e7bcc7e 
472: Add const reference handling test for `let_value` r=msimberg a=aurianer

Add reference handling test for `let_value` sender.
Fix partially #284

Co-authored-by: Auriane R <aurianer@cscs.ch>
Co-authored-by: aurianer <aurianer@cscs.ch>
bors bot added a commit that referenced this issue Oct 10, 2022
@bors @aurianer
Merge #472
58ed143 
472: Add const reference handling test for `let_value` r=msimberg a=aurianer

Add reference handling test for `let_value` sender.
Fix partially #284

Co-authored-by: Auriane R <aurianer@cscs.ch>
Co-authored-by: aurianer <aurianer@cscs.ch>
bors bot added a commit that referenced this issue Oct 10, 2022
@bors @aurianer
Merge #472
a1824c1 
472: Add const reference handling test for `let_value` r=msimberg a=aurianer

Add reference handling test for `let_value` sender.
Fix partially #284

Co-authored-by: Auriane R <aurianer@cscs.ch>
Co-authored-by: aurianer <aurianer@cscs.ch>
bors bot added a commit that referenced this issue Oct 13, 2022
@bors @aurianer
Merge #474
9c08ed3 
474: Add a const reference handling test for `start_detached` r=msimberg a=aurianer

Fixes partially #284.

Co-authored-by: Auriane R <aurianer@cscs.ch>
Co-authored-by: aurianer <aurianer@cscs.ch>
bors bot added a commit that referenced this issue Oct 13, 2022
@bors @aurianer
Merge #474
79031d3 
474: Add a const reference handling test for `start_detached` r=msimberg a=aurianer

Fixes partially #284.

Co-authored-by: Auriane R <aurianer@cscs.ch>
Co-authored-by: aurianer <aurianer@cscs.ch>
bors bot added a commit that referenced this issue Oct 13, 2022
@bors @aurianer
Merge #474
1a84934 
474: Add a const reference handling test for `start_detached` r=aurianer a=aurianer

Fixes partially #284.

Co-authored-by: Auriane R <aurianer@cscs.ch>
Co-authored-by: aurianer <aurianer@cscs.ch>
bors bot added a commit that referenced this issue Oct 14, 2022
@bors @aurianer
Merge #474
25701e7 
474: Add a const reference handling test for `start_detached` r=aurianer a=aurianer

Fixes partially #284.

Co-authored-by: Auriane R <aurianer@cscs.ch>
Co-authored-by: aurianer <aurianer@cscs.ch>
bors bot added a commit that referenced this issue Oct 14, 2022
@bors @aurianer
Merge #474
5198ef6 
474: Add a const reference handling test for `start_detached` r=msimberg a=aurianer

Fixes partially #284.

Co-authored-by: Auriane R <aurianer@cscs.ch>
Co-authored-by: aurianer <aurianer@cscs.ch>
bors bot added a commit that referenced this issue Oct 14, 2022
@bors @aurianer
Merge #474
71192b1 
474: Add a const reference handling test for `start_detached` r=aurianer a=aurianer

Fixes partially #284.

Co-authored-by: Auriane R <aurianer@cscs.ch>
Co-authored-by: aurianer <aurianer@cscs.ch>
@aurianer aurianer mentioned this issue Oct 14, 2022
Merged
bors bot added a commit that referenced this issue Oct 25, 2022
@bors @aurianer
Merge #484
cac08bc 
484: Add tests for reference types to `when_all_vector` r=msimberg a=aurianer

Last part of #284. Fixes #284.

Co-authored-by: aurianer <aurianer@cscs.ch>
@bors bors bot closed this as completed in 900de94 Oct 25, 2022
Repository owner moved this from In Progress to Done in pika planning board Oct 25, 2022
@msimberg msimberg mentioned this issue Oct 28, 2022
Merged
@msimberg msimberg moved this from Done to Archive in pika planning board Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aurianer aurianer

Labels
effort: 2 A few hours of work. priority: high This is essential functionality or a serious bug. Not addressing this blocks progress. type: bug
Projects
pika planning board
Archived in project
Milestone
0.10.0
2 participants
@msimberg @aurianer