Add `when_all` test and handling for const reference error types #320

aurianer · 2022-07-13T09:59:25Z

Partially fixes #284

aurianer · 2022-07-13T09:59:43Z

bors try

bors · 2022-07-13T10:00:28Z

try

Build failed:

ci/circleci: clang_format

msimberg

Some minor changes required, but looks good otherwise!

libs/pika/execution/tests/include/algorithm_test_utils.hpp

msimberg · 2022-07-13T11:12:39Z

Merging is of course currently not going to work with bors since daint is down. Let's wait a few days to see if they can resolve the problems. Otherwise we can hopefully go with only the GitHub actions and CircleCI checks.

aurianer · 2022-07-13T14:13:52Z

bors try

pika-bot · 2022-07-13T15:32:01Z

Performance test report

pika Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	(=)	+

Info

Property	Before	After
pika Datetime	2021-12-21T15:01:46+00:00	2022-07-13T14:05:38+00:00
pika Commit	01e4980e2184ca113b853ae3a36869f713fcc4b9	`22b0484`
Hostname	nid00932	nid00271
Datetime	2021-12-21T16:09:15.238666+01:00	2022-07-13T17:30:54.643491+02:00
Envfile
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clustername	daint	daint

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	+++

Info

Property	Before	After
pika Datetime	2021-12-10T13:50:04+00:00	2022-07-13T14:05:38+00:00
pika Commit	f499a2233385060b8a2612ab88163e62b0881888	`22b0484`
Hostname	nid00243	nid00271
Datetime	2021-12-10T15:19:42.442217+01:00	2022-07-13T17:31:09.157461+02:00
Envfile
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clustername	daint	daint

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
Stream Benchmark - Add	(=)	=	(=)
Stream Benchmark - Scale	-	--	---
Stream Benchmark - Triad	(=)	-	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
pika Datetime	2021-11-12T11:29:27+00:00	2022-07-13T14:05:38+00:00
pika Commit	f64fbd02165a132a6276cedd14c586910abb79e4	`22b0484`
Hostname	nid00007	nid00271
Datetime	2021-11-12T12:57:50.824026+01:00	2022-07-13T17:31:23.827641+02:00
Envfile
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clustername	daint	daint

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

pika-bot · 2022-07-13T15:44:10Z

Performance test report

pika Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	(=)	+

Info

Property	Before	After
pika Datetime	2021-12-21T15:01:46+00:00	2022-07-13T14:05:38+00:00
pika Commit	01e4980e2184ca113b853ae3a36869f713fcc4b9	`22b0484`
Envfile
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime	2021-12-21T16:09:15.238666+01:00	2022-07-13T17:43:02.474476+02:00
Hostname	nid00932	nid00262
Clustername	daint	daint

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	+++

Info

Property	Before	After
pika Datetime	2021-12-10T13:50:04+00:00	2022-07-13T14:05:38+00:00
pika Commit	f499a2233385060b8a2612ab88163e62b0881888	`22b0484`
Envfile
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime	2021-12-10T15:19:42.442217+01:00	2022-07-13T17:43:16.788010+02:00
Hostname	nid00243	nid00262
Clustername	daint	daint

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
Stream Benchmark - Add	-	=	(=)
Stream Benchmark - Scale	---	--	---
Stream Benchmark - Triad	-	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
pika Datetime	2021-11-12T11:29:27+00:00	2022-07-13T14:05:38+00:00
pika Commit	f64fbd02165a132a6276cedd14c586910abb79e4	`22b0484`
Envfile
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime	2021-11-12T12:57:50.824026+01:00	2022-07-13T17:43:31.663511+02:00
Hostname	nid00007	nid00262
Clustername	daint	daint

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

bors · 2022-07-13T16:15:59Z

try

Build failed:

jenkins/cscs/clang-13-debug

pika-bot · 2022-07-13T16:49:39Z

Performance test report

pika Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	(=)	+

Info

Property	Before	After
pika Datetime	2021-12-21T15:01:46+00:00	2022-07-13T16:41:46+00:00
pika Commit	01e4980e2184ca113b853ae3a36869f713fcc4b9	`babb873`
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostname	nid00932	nid00166
Clustername	daint	daint
Envfile
Datetime	2021-12-21T16:09:15.238666+01:00	2022-07-13T18:48:46.747884+02:00

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	+++

Info

Property	Before	After
pika Datetime	2021-12-10T13:50:04+00:00	2022-07-13T16:41:46+00:00
pika Commit	f499a2233385060b8a2612ab88163e62b0881888	`babb873`
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostname	nid00243	nid00166
Clustername	daint	daint
Envfile
Datetime	2021-12-10T15:19:42.442217+01:00	2022-07-13T18:49:01.651507+02:00

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
Stream Benchmark - Add	(=)	=	--
Stream Benchmark - Scale	-	--	--
Stream Benchmark - Triad	(=)	-	-
Stream Benchmark - Copy	(=)	(=)	=

Info

Property	Before	After
pika Datetime	2021-11-12T11:29:27+00:00	2022-07-13T16:41:46+00:00
pika Commit	f64fbd02165a132a6276cedd14c586910abb79e4	`babb873`
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostname	nid00007	nid00166
Clustername	daint	daint
Envfile
Datetime	2021-11-12T12:57:50.824026+01:00	2022-07-13T18:49:16.378157+02:00

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

libs/pika/execution/tests/include/algorithm_test_utils.hpp

msimberg · 2022-07-14T07:39:33Z

Make sure you also check this failure: https://app.circleci.com/pipelines/github/pika-org/pika/2121/workflows/ea660918-a3d9-4f48-867d-b635e7be6915/jobs/21088/steps?invite=true#step-102-113.

pika-bot · 2022-07-14T10:10:11Z

Performance test report

pika Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	(=)	+

Info

Property	Before	After
pika Commit	01e4980e2184ca113b853ae3a36869f713fcc4b9	`9972253`
pika Datetime	2021-12-21T15:01:46+00:00	2022-07-14T10:02:18+00:00
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostname	nid00932	nid00025
Datetime	2021-12-21T16:09:15.238666+01:00	2022-07-14T12:09:16.594330+02:00
Envfile
Clustername	daint	daint

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	+++

Info

Property	Before	After
pika Commit	f499a2233385060b8a2612ab88163e62b0881888	`9972253`
pika Datetime	2021-12-10T13:50:04+00:00	2022-07-14T10:02:18+00:00
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostname	nid00243	nid00025
Datetime	2021-12-10T15:19:42.442217+01:00	2022-07-14T12:09:31.296225+02:00
Envfile
Clustername	daint	daint

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
pika Commit	f64fbd02165a132a6276cedd14c586910abb79e4	`9972253`
pika Datetime	2021-11-12T11:29:27+00:00	2022-07-14T10:02:18+00:00
Compiler	/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostname	nid00007	nid00025
Datetime	2021-11-12T12:57:50.824026+01:00	2022-07-14T12:09:45.904743+02:00
Envfile
Clustername	daint	daint

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

aurianer · 2022-07-14T10:16:35Z

bors try

msimberg · 2022-07-14T10:40:26Z

bors merge

bors · 2022-07-14T10:42:22Z

try

Build succeeded:

bors · 2022-07-14T10:53:55Z

Already running a review

bors · 2022-07-14T11:15:39Z

Build succeeded:

aurianer added the category: senders/receivers P2300 label Jul 13, 2022

aurianer added this to the 0.7.0 milestone Jul 13, 2022

aurianer requested review from biddisco and msimberg as code owners July 13, 2022 09:59

bors bot added a commit that referenced this pull request Jul 13, 2022

Try #320:

d723db0

msimberg requested changes Jul 13, 2022

View reviewed changes

libs/pika/execution/tests/include/algorithm_test_utils.hpp Outdated Show resolved Hide resolved

libs/pika/execution/tests/include/algorithm_test_utils.hpp Outdated Show resolved Hide resolved

aurianer force-pushed the reference_handling_when_all branch from 90fcecd to 97e3897 Compare July 13, 2022 14:05

bors bot added a commit that referenced this pull request Jul 13, 2022

Try #320:

198e488

aurianer force-pushed the reference_handling_when_all branch from 97e3897 to b052c68 Compare July 13, 2022 16:41

msimberg assigned aurianer Jul 14, 2022

msimberg changed the title ~~Add when_all test and handling for const reference exceptions~~ Add when_all test and handling for const reference exceptions Jul 14, 2022

msimberg changed the title ~~Add when_all test and handling for const reference exceptions~~ Add when_all test and handling for const reference error types Jul 14, 2022

msimberg reviewed Jul 14, 2022

View reviewed changes

libs/pika/execution/tests/include/algorithm_test_utils.hpp Show resolved Hide resolved

msimberg mentioned this pull request Jul 14, 2022

Enable tests for P2300 reference implementation split #285

Merged

1 task

aurianer added 2 commits July 14, 2022 12:02

Add when_all test for const reference exceptions

b863c04

Clean up other error_sender test facilities

4205c68

aurianer force-pushed the reference_handling_when_all branch from b052c68 to 4205c68 Compare July 14, 2022 10:02

bors bot added a commit that referenced this pull request Jul 14, 2022

Try #320:

3cefe27

msimberg approved these changes Jul 14, 2022

View reviewed changes

bors bot merged commit a2bf280 into pika-org:main Jul 14, 2022

aurianer mentioned this pull request Oct 4, 2022

Fix handling of value_types and error_types with references in all sender adaptors #284

Closed

12 tasks

Add when_all test and handling for const reference error types #320

Add when_all test and handling for const reference error types #320

Conversation

aurianer commented Jul 13, 2022 • edited Loading

aurianer commented Jul 13, 2022

bors bot commented Jul 13, 2022

try

msimberg left a comment

Choose a reason for hiding this comment

msimberg commented Jul 13, 2022

aurianer commented Jul 13, 2022

pika-bot commented Jul 13, 2022

pika Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

pika-bot commented Jul 13, 2022

pika Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

bors bot commented Jul 13, 2022

try

pika-bot commented Jul 13, 2022

pika Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

msimberg commented Jul 14, 2022

pika-bot commented Jul 14, 2022

pika Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

aurianer commented Jul 14, 2022

msimberg commented Jul 14, 2022

bors bot commented Jul 14, 2022

try

bors bot commented Jul 14, 2022

bors bot commented Jul 14, 2022

Add `when_all` test and handling for const reference error types #320

Add `when_all` test and handling for const reference error types #320

aurianer commented Jul 13, 2022 •

edited

Loading