Checking for CMAKE_CUDA_STANDARD when finding pika may be overly strict
#392
Assignees
Labels
category: CMake
category: CUDA
category: HIP
effort: 2
A few hours of work.
priority: medium
This should be done sooner or later.
type: bug
type: cleanup
Milestone
Comments
msimberg
added
effort: 2
bors bot
added a commit
that referenced
this issue
Aug 23, 2022
377: Clean up `algorithms` module part 1 r=msimberg a=msimberg Part of #16. Moves some functionality in `algorithms` into detail, but not all. Concatenates nested namespaces (and I found out about https://clang.llvm.org/extra/clang-tidy/checks/modernize/concat-nested-namespaces.html, which I think we can enable in the clang-tidy config). There's so much to change in the algorithms module that I'm leaving this PR in the current stage except for build errors and continuing in a separate PR once this is in. 396: Check `PIKA_CUDA_STANDARD` and `CMAKE_CUDA_STANDARD` compatibility only when building pika itself r=msimberg a=msimberg Also, don't set `CMAKE_CUDA_STANDARD` when finding pika (`cuda_std_xx` is meant to ensure that at least a minimum standard is available). Closes #392. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
bors bot
added a commit
that referenced
this issue
Aug 23, 2022
396: Check `PIKA_CUDA_STANDARD` and `CMAKE_CUDA_STANDARD` compatibility only when building pika itself r=msimberg a=msimberg Also, don't set `CMAKE_CUDA_STANDARD` when finding pika (`cuda_std_xx` is meant to ensure that at least a minimum standard is available). Closes #392. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
bors bot
added a commit
that referenced
this issue
Aug 23, 2022
396: Check `PIKA_CUDA_STANDARD` and `CMAKE_CUDA_STANDARD` compatibility only when building pika itself r=msimberg a=msimberg Also, don't set `CMAKE_CUDA_STANDARD` when finding pika (`cuda_std_xx` is meant to ensure that at least a minimum standard is available). Closes #392. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
Repository owner
moved this from In Progress
to Done
in pika planning board
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently check that
CMAKE_CUDA_STANDARDis not set inpika_setup_cuda.cmake. This is primarily meant to be checked when configuring and building pika itself. However, the check is currently enabled also when finding pika as a dependency. I think we should not be checking for this since compile features make sure that consumers of pika have the correct standard set.The text was updated successfully, but these errors were encountered: