Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check PIKA_WITH_CXX_STANDARD and CMAKE_CUDA_STANDARD compatibility only when building pika itself #396

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Check PIKA_WITH_CXX_STANDARD and CMAKE_CUDA_STANDARD compatibility only when building pika itself #396

merged 1 commit into from
Aug 23, 2022

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Aug 22, 2022 •
edited
Loading

Also, don't set CMAKE_CUDA_STANDARD when finding pika (cuda_std_xx is meant to ensure that at least a minimum standard is available). Closes #392.

@msimberg msimberg added this to the 0.8.0 milestone Aug 22, 2022
@msimberg msimberg marked this pull request as ready for review August 22, 2022 18:09
@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 22, 2022
@bors
Try #396:
6604749
aurianer
aurianer approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@bors
Copy link
Contributor

bors bot commented Aug 22, 2022

try

Build failed:

@msimberg msimberg self-assigned this Aug 23, 2022
@msimberg msimberg force-pushed the relax-cmake_cuda_standard-check branch from 91878a1 to 77833bf Compare August 23, 2022 08:30
@msimberg
Copy link
Contributor Author

bors merge

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d498ea9f
pika Datetime2022-05-17T10:12:00+00:002022-08-23T08:30:48+00:00
Envfile
Datetime2022-05-17T12:20:04.953138+02:002022-08-23T10:38:54.107007+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint
Hostnamenid01398nid00025

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch=

Info

PropertyBeforeAfter
pika Commit453f6a4498ea9f
pika Datetime2022-06-24T10:19:16+00:002022-08-23T08:30:48+00:00
Envfile
Datetime2022-06-24T12:43:43.615347+02:002022-08-23T10:39:08.891902+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint
Hostnamenid00025nid00025

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add(=)(=)-
Stream Benchmark - Scale+++=+++
Stream Benchmark - Triad++(=)+
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d498ea9f
pika Datetime2022-05-17T10:12:00+00:002022-08-23T08:30:48+00:00
Envfile
Datetime2022-05-17T12:20:34.006375+02:002022-08-23T10:39:23.668146+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint
Hostnamenid01398nid00025

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg msimberg force-pushed the relax-cmake_cuda_standard-check branch from 77833bf to 52c6bbe Compare August 23, 2022 09:59
@bors
Copy link
Contributor

bors bot commented Aug 23, 2022

Canceled.

@msimberg
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Aug 23, 2022
@bors @msimberg
Merge #377 #396
4e38fa5 
377: Clean up `algorithms` module part 1 r=msimberg a=msimberg

Part of #16. Moves some functionality in `algorithms` into detail, but not all. Concatenates nested namespaces (and I found out about https://clang.llvm.org/extra/clang-tidy/checks/modernize/concat-nested-namespaces.html, which I think we can enable in the clang-tidy config). There's so much to change in the algorithms module that I'm leaving this PR in the current stage except for build errors and continuing in a separate PR once this is in.

396: Check `PIKA_CUDA_STANDARD` and `CMAKE_CUDA_STANDARD` compatibility only when building pika itself r=msimberg a=msimberg

Also, don't set `CMAKE_CUDA_STANDARD` when finding pika (`cuda_std_xx` is meant to ensure that at least a minimum standard is available). Closes #392.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2022

Build failed (retrying...):

bors bot added a commit that referenced this pull request Aug 23, 2022
@bors @msimberg
Merge #396
b754021 
396: Check `PIKA_CUDA_STANDARD` and `CMAKE_CUDA_STANDARD` compatibility only when building pika itself r=msimberg a=msimberg

Also, don't set `CMAKE_CUDA_STANDARD` when finding pika (`cuda_std_xx` is meant to ensure that at least a minimum standard is available). Closes #392.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2022

Build failed:

@msimberg
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Aug 23, 2022
@bors @msimberg
Merge #396
df498e4 
396: Check `PIKA_CUDA_STANDARD` and `CMAKE_CUDA_STANDARD` compatibility only when building pika itself r=msimberg a=msimberg

Also, don't set `CMAKE_CUDA_STANDARD` when finding pika (`cuda_std_xx` is meant to ensure that at least a minimum standard is available). Closes #392.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Aug 23, 2022

Build failed:

@aurianer
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 23, 2022

Build succeeded:

@bors bors bot merged commit 44ffcaf into pika-org:main Aug 23, 2022
@msimberg msimberg mentioned this pull request Aug 25, 2022
Merged
@msimberg msimberg changed the title Check PIKA_CUDA_STANDARD and CMAKE_CUDA_STANDARD compatibility only when building pika itself Check PIKA_WITH_CXX_STANDARD and CMAKE_CUDA_STANDARD compatibility only when building pika itself Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Checking for CMAKE_CUDA_STANDARD when finding pika may be overly strict
3 participants
@msimberg @pika-bot @aurianer