Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup runtime module - part 2 #1091

Merged
merged 9 commits into from
May 6, 2024

Conversation

aurianer
Copy link
Contributor

Fixes partially #16.

Based on #826.

@aurianer aurianer self-assigned this Apr 10, 2024
@aurianer aurianer added this to the 0.25.0 milestone Apr 10, 2024
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit0abc08475cb8bc
pika Datetime2024-02-19T15:15:15+00:002024-04-10T14:13:23+00:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Clusternamedaintdaint
Hostnamenid00025nid00025
Datetime2024-02-19T16:26:16.072067+01:002024-04-10T16:23:50.830177+02:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer force-pushed the cleanup_runtime_module_part_2 branch 3 times, most recently from 3f2cf68 to b7e1671 Compare April 12, 2024 10:24
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit0abc084b61f479
pika Datetime2024-02-19T15:15:15+00:002024-04-12T10:24:01+00:00
Hostnamenid00025nid00459
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint
Datetime2024-02-19T16:26:16.072067+01:002024-04-12T12:33:58.883212+02:00
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer force-pushed the cleanup_runtime_module_part_2 branch from b7e1671 to a036b6c Compare May 2, 2024 11:41
@aurianer aurianer marked this pull request as ready for review May 2, 2024 11:42
@aurianer aurianer requested review from biddisco and msimberg as code owners May 2, 2024 11:42
@msimberg msimberg enabled auto-merge May 3, 2024 08:52
@msimberg msimberg added this pull request to the merge queue May 6, 2024
@msimberg msimberg force-pushed the cleanup_runtime_module_part_2 branch from f3db03e to c41daf6 Compare May 6, 2024 11:07
@msimberg msimberg removed this pull request from the merge queue due to a manual request May 6, 2024
@msimberg msimberg enabled auto-merge May 6, 2024 11:07
@msimberg msimberg added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@msimberg msimberg force-pushed the cleanup_runtime_module_part_2 branch from c41daf6 to 1585931 Compare May 6, 2024 14:01
@msimberg msimberg enabled auto-merge May 6, 2024 14:03
@msimberg msimberg added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@msimberg msimberg added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@msimberg msimberg merged commit 9d7ae49 into pika-org:main May 6, 2024
37 of 38 checks passed
@aurianer aurianer deleted the cleanup_runtime_module_part_2 branch July 2, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

3 participants