Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup runtime module - part 1 #826

Merged
merged 12 commits into from
Apr 15, 2024

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Oct 25, 2023

Fixes partially #16. Part 2 in #1091.

@aurianer aurianer added this to the 0.20.0 milestone Oct 25, 2023
@aurianer aurianer self-assigned this Oct 25, 2023
@msimberg msimberg modified the milestones: 0.20.0, 0.21.0 Oct 30, 2023
@aurianer aurianer force-pushed the cleanup_runtime_module branch from e630c4f to 14ef41f Compare November 1, 2023 13:19
@msimberg msimberg removed this from the 0.21.0 milestone Dec 5, 2023
@pika-bot
Copy link
Collaborator

pika-bot commented Jan 5, 2024

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit02f9de89cd38b2
pika Datetime2023-08-21T11:44:55+00:002024-01-05T09:15:58+00:00
Hostnamenid01181nid01322
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime2023-08-21T13:50:51.685166+02:002024-01-05T10:27:53.259914+01:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg
Copy link
Contributor

@aurianer what's the status of this? Is there anything missing? Would you need help with anything?

@aurianer
Copy link
Contributor Author

I will go through my notes again next week for this, thanks for pointing it out

@aurianer aurianer force-pushed the cleanup_runtime_module branch 2 times, most recently from a90b047 to 8ada7a6 Compare March 1, 2024 13:08
@msimberg msimberg added this to the 0.24.0 milestone Mar 14, 2024
@aurianer aurianer force-pushed the cleanup_runtime_module branch from 8ada7a6 to 26ad0c8 Compare April 9, 2024 14:25
@aurianer aurianer changed the title Cleanup runtime module Cleanup runtime module part 1 Apr 9, 2024
@aurianer aurianer changed the title Cleanup runtime module part 1 Cleanup runtime module - part 1 Apr 9, 2024
@aurianer aurianer marked this pull request as ready for review April 9, 2024 14:26
@aurianer aurianer force-pushed the cleanup_runtime_module branch 2 times, most recently from 686b049 to c7862a6 Compare April 10, 2024 14:04
@aurianer aurianer force-pushed the cleanup_runtime_module branch 2 times, most recently from 747f380 to d539fea Compare April 11, 2024 10:35
@msimberg msimberg added this pull request to the merge queue Apr 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 11, 2024
@aurianer aurianer force-pushed the cleanup_runtime_module branch from d539fea to f8e19f3 Compare April 11, 2024 13:32
@msimberg msimberg removed this from the 0.24.0 milestone Apr 12, 2024
@msimberg msimberg added this to the 0.25.0 milestone Apr 12, 2024
@aurianer aurianer force-pushed the cleanup_runtime_module branch from f8e19f3 to ab9e5c4 Compare April 12, 2024 10:21
@aurianer aurianer enabled auto-merge April 12, 2024 10:22
@aurianer aurianer added this pull request to the merge queue Apr 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2024
@msimberg msimberg merged commit a219798 into pika-org:main Apr 15, 2024
37 of 38 checks passed
@aurianer aurianer deleted the cleanup_runtime_module branch July 2, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

3 participants