Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce spinlock detection limits now that spinlocks do backoff #1098

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Apr 18, 2024

After #927 spin_k and yield_k go through iterations much slower. This means that the spinlock deadlock warnings may not be printed in any reasonable time with the old limits. This reduces the error limit by an order of magnitude, and the warning limit by two orders of magnitude (since this is typically the interesting message, and it's harmless when printed). The limits can still be changed with configuration options as before, and the detection is still opt-in.

@msimberg msimberg added this to the 0.25.0 milestone Apr 18, 2024
@msimberg msimberg self-assigned this Apr 18, 2024
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Commit0abc0845415ea1
pika Datetime2024-02-19T15:15:15+00:002024-04-18T15:42:43+00:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid00025nid00025
Datetime2024-02-19T16:26:16.072067+01:002024-04-18T17:49:51.107061+02:00
Clusternamedaintdaint
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg msimberg force-pushed the spinlock-detection-limits branch from e8e8a3c to 21ae9ab Compare April 19, 2024 08:17
@msimberg msimberg merged commit 8c774df into pika-org:main Apr 22, 2024
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

2 participants