Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spin_k and yield_k performance by pausing more #927

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Jan 5, 2024

  • In yield_k, pause every iteration before actually yielding
  • In spin_k, add a simple backoff by spinning inside spin_k k times before returning

Especially the latter improves performance of contended barriers on Grace.

@msimberg msimberg added this to the 0.22.0 milestone Jan 5, 2024
@msimberg msimberg self-assigned this Jan 5, 2024
@msimberg
Copy link
Contributor Author

msimberg commented Jan 5, 2024

cscs-ci run

@msimberg msimberg added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@msimberg msimberg added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@msimberg msimberg merged commit c9a62e5 into pika-org:main Jan 8, 2024
66 checks passed
@msimberg msimberg deleted the better-spin branch January 8, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant