Increase timeout for container algorithms tests on macOS CI configuration #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors merge |
Performance test reportpika PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
bors bot
added a commit
that referenced
this pull request
Aug 8, 2022
330: Update CUDA sender functionality to work with P2300 reference implementation r=msimberg a=msimberg Continuation of #315. Part 2/n to fix #302. This has now been tested with clang 14 and CUDA. ~but a CI configuration will follow in a separate PR (the llvm build requires this patch: spack/spack#31661 - Makes `get_env` customizations `noexcept` as required (and enforced) by the P2300 reference implementation. - Add a missing `range` header to `cuda_scheduler_bulk.hpp`. - ADL-isolate sender and receiver types in `async_cuda` module. - Fixes the `completion_signatures` for senders in `async_cuda`. Note that the helpers for computing the types have to be guarded with a `requires is_invocable_v...` because `make_completion_signatures` instantiates the helper with non-`set_value_t` signatures as well. I have to investigate whether this is a bug or expected behaviour. - Because of the above, a number of helper "kernels" have received trailing `decltype`s to enable SFINAE with bogus arguments. - Removes the SFINAE for `then_with_cuda_stream` etc. since the HIP branch has been merged into DLA-Future. The SFINAE is no longer needed for choosing a `then_with_*` overload and adds unnecessary complexity. - The reference implementation's `split` does not yet support move-only senders, so some additional tests are disabled with CUDA and the reference implementation. - Change the `clang-14` Jenkins configuration to use CUDA and the P2300 reference implementation. Note, this is not for 0.7.0 as it needs more work. Reviews are, however, already welcome. 346: Remove `operator|` overloads for `sync_wait` and `start_detached` r=msimberg a=msimberg Fixes #329 . 347: Add Codacy coverage report r=msimberg a=msimberg Part of #4. Not fully tested, but I got some reporting already to Codacy so there is hope that this works... To do: - [x] badge 352: Increase timeout for container algorithms tests on macOS CI configuration r=msimberg a=msimberg I'm increasing the timeout to check if these timeouts https://github.com/pika-org/pika/runs/7692289838?check_suite_focus=true#step:6:237 are simply due to the test taking long to complete or if it really hangs. `partial_sort_copy_range` is one of the longer running tests so it's possible that it indeed just doesn't have enough time to finish (the timeout is 120 seconds and one of the later runs finished in 101 seconds: https://github.com/pika-org/pika/runs/7691710341?check_suite_focus=true#step:6:237). Co-authored-by: Mikael Simberg <simberg@cscs.ch> Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Aug 8, 2022
347: Add Codacy coverage report r=msimberg a=msimberg Part of #4. Not fully tested, but I got some reporting already to Codacy so there is hope that this works... To do: - [x] badge 352: Increase timeout for container algorithms tests on macOS CI configuration r=msimberg a=msimberg I'm increasing the timeout to check if these timeouts https://github.com/pika-org/pika/runs/7692289838?check_suite_focus=true#step:6:237 are simply due to the test taking long to complete or if it really hangs. `partial_sort_copy_range` is one of the longer running tests so it's possible that it indeed just doesn't have enough time to finish (the timeout is 120 seconds and one of the later runs finished in 101 seconds: https://github.com/pika-org/pika/runs/7691710341?check_suite_focus=true#step:6:237). Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Aug 9, 2022
360: Increase algorithms tests timeout in macOS workflow r=msimberg a=msimberg Follow-up to #352. Also increase the timeout for the algorithms tests. `partial_sort_copy` (like `partial_sort_copy_range`) takes long to complete, most likely just due to insufficient time. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm increasing the timeout to check if these timeouts https://github.com/pika-org/pika/runs/7692289838?check_suite_focus=true#step:6:237 are simply due to the test taking long to complete or if it really hangs.
partial_sort_copy_rangeis one of the longer running tests so it's possible that it indeed just doesn't have enough time to finish (the timeout is 120 seconds and one of the later runs finished in 101 seconds: https://github.com/pika-org/pika/runs/7691710341?check_suite_focus=true#step:6:237).