Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase algorithms tests timeout in macOS workflow #360

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Increase algorithms tests timeout in macOS workflow #360

merged 1 commit into from
Aug 9, 2022

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Aug 9, 2022

Follow-up to #352. Also increase the timeout for the algorithms tests. partial_sort_copy (like partial_sort_copy_range) takes long to complete, most likely just due to insufficient time.

@msimberg msimberg added this to the 0.8.0 milestone Aug 9, 2022
@msimberg msimberg self-assigned this Aug 9, 2022
@msimberg
Copy link
Contributor Author

msimberg commented Aug 9, 2022

bors merge

@pika-bot
Copy link
Collaborator

pika-bot commented Aug 9, 2022

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d53d8247
pika Datetime2022-05-17T10:12:00+00:002022-08-09T10:14:31+00:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime2022-05-17T12:20:04.953138+02:002022-08-09T12:21:54.455564+02:00
Envfile
Clusternamedaintdaint
Hostnamenid01398nid01121

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch=

Info

PropertyBeforeAfter
pika Commit453f6a453d8247
pika Datetime2022-06-24T10:19:16+00:002022-08-09T10:14:31+00:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime2022-06-24T12:43:43.615347+02:002022-08-09T12:22:09.399161+02:00
Envfile
Clusternamedaintdaint
Hostnamenid00025nid01121

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add(=)-(=)
Stream Benchmark - Scale+++(=)+++
Stream Benchmark - Triad+++++
Stream Benchmark - Copy(=)=(=)

Info

PropertyBeforeAfter
pika Commitd45937d53d8247
pika Datetime2022-05-17T10:12:00+00:002022-08-09T10:14:31+00:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime2022-05-17T12:20:34.006375+02:002022-08-09T12:22:24.066762+02:00
Envfile
Clusternamedaintdaint
Hostnamenid01398nid01121

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@bors
Copy link
Contributor

bors bot commented Aug 9, 2022

Build succeeded:

@bors bors bot merged commit 3930832 into main Aug 9, 2022
@bors bors bot deleted the msimberg-patch-1 branch August 9, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msimberg @pika-bot