Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: cherry-pick some PRs (#1458) #1460

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 25, 2022

What problem does this PR solve?

cherry-pick pingcap/tidb#27769

also cherry-pick pingcap/tidb#29730 to pass integration test

also partically cherry-pick pingcap/tidb#29062 to fix some unstable integration tests

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Fix the bug that import from s3 may fail if the csv file size is similar to region-split-size(default is 256MiB).

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/L and removed size/XL labels Jan 25, 2022
@glorv
Copy link
Collaborator

glorv commented Jan 25, 2022

/build

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jan 25, 2022
@glorv glorv assigned zhouqiang-cl and unassigned glorv and nongfushanquan Jan 26, 2022
@glorv
Copy link
Collaborator

glorv commented Jan 26, 2022

/cc @zhouqiang-cl PTAL

@ti-chi-bot
Copy link
Member Author

@glorv: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @zhouqiang-cl PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glorv
Copy link
Collaborator

glorv commented Jan 26, 2022

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 7a935d5

@glorv
Copy link
Collaborator

glorv commented Feb 8, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 0ef10e6 into pingcap:release-5.1 Feb 8, 2022
@zhouqiang-cl zhouqiang-cl added this to the v5.1.4 milestone Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants