Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br/lightning: fix the integration test cases #29062

Merged
merged 13 commits into from
Oct 27, 2021
Merged

br/lightning: fix the integration test cases #29062

merged 13 commits into from
Oct 27, 2021

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Oct 25, 2021 •
edited
Loading

What problem does this PR solve?

Problem Summary:
Fix ci cases for br/lightning.

What is changed and how it works?

This PR tried to fix these test cases:

  1. br_other: some configs' default value of PD has changed. max-pending-peer-count and max-snapshot-count raised to 64. so I think we can ignore these configs in test case.
  2. lightning_checkpoint_dirty_tableid: After lightning: do not output pre-check info when disable check-requirements #27934 lightning's CI lightning-checkpoint-dirty-tableid failed. due to some checks still enable even --check-requirements=false.
  3. lightning_duplicate_detection: skip for temporary. CI: lightning_duplicate_detection test case failed. #29178
  4. lightning_examples: fix the wrong path.
  5. lightning_error_summary: skip for temporary.CI: lightning_error_summary test case failed. #29177

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 25, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2021
@3pointer
Copy link
Contributor Author

/run-br-integration-tests

@3pointer
Copy link
Contributor Author

/run-integration-br-test

@3pointer
Copy link
Contributor Author

/run-integration-br-test

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2021
@3pointer
Copy link
Contributor Author

/run-integration-br-test

@3pointer
Copy link
Contributor Author

/run-integration-br-test

@3pointer 3pointer added component/br This issue is related to BR of TiDB. component/lightning This issue is related to Lightning of TiDB. labels Oct 27, 2021
@3pointer
Copy link
Contributor Author

/run-integration-br-test

@3pointer 3pointer changed the title lightning: fix the wrong skipped clean up br/lightning: fix the integration test cases Oct 27, 2021
@3pointer
Copy link
Contributor Author

/run-integration-br-test

@3pointer
Copy link
Contributor Author

/run-integration-br-test

@3pointer 3pointer marked this pull request as ready for review October 27, 2021 07:00
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2021
YuJuncen
YuJuncen approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/tests/lightning_error_summary/run.sh Outdated
@@ -16,6 +16,8 @@

set -eux

#skip for temporary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add the reason and log to stdout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, add the simple reason.

Actually, this case failed due to ERRORCODE is 0(success), but we have insert some value before lightning starts, so we expect the checksum failed and ERRORCODE is not 0.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2021
@3pointer
Copy link
Contributor Author

/run-integration-br-test

@kennytm
Copy link
Contributor

kennytm commented Oct 27, 2021

please file issues for the two skipped tests.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2021
@3pointer
Copy link
Contributor Author

please file issues for the two skipped tests.

sure, I'll do it

@3pointer
Copy link
Contributor Author

please file issues for the two skipped tests.

Add in PR description.

@kennytm
Copy link
Contributor

kennytm commented Oct 27, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 554e2f3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2021
@ti-chi-bot
Copy link
Member

@3pointer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit e60e170 into pingcap:master Oct 27, 2021
@glorv glorv mentioned this pull request Jan 24, 2022
Merged
This was referenced Jan 25, 2022
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
component/br This issue is related to BR of TiDB. component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@3pointer @ti-chi-bot @kennytm @YuJuncen