This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
pdutil: use temp pause config #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overvenus
reviewed
Nov 10, 2020
pkg/pdutil/pd.go
Outdated
| if failure == nil { | ||
| break | ||
| } | ||
| } | ||
| if failure != nil { | ||
| return nil, errors.Annotatef(failure, "pd address (%s) not available, please check network", pdAddrs) | ||
| } | ||
| version, err := semver.NewVersion(string(versionBytes)) | ||
| if err != nil { | ||
| return nil, errors.Annotatef(err, "transform pd version failed", string(versionBytes)) |
There was a problem hiding this comment.
Could you choose an error in pkg/errors?
3pointer
force-pushed
the
pd_temp_config
branch
2 times, most recently
from
8ac48a5
to
668a2c9
Compare
3pointer
force-pushed
the
pd_temp_config
branch
from
668a2c9
to
7cf0c64
Compare
|
/rebuild |
3pointer
force-pushed
the
pd_temp_config
branch
from
e63d085
to
99692eb
Compare
3pointer
force-pushed
the
pd_temp_config
branch
from
b3fdef9
to
64d6d4c
Compare
kennytm
reviewed
Nov 11, 2020
|
/run-integration-test |
3pointer
force-pushed
the
pd_temp_config
branch
from
f7552b6
to
002f54c
Compare
kennytm
reviewed
Nov 12, 2020
pkg/pdutil/pd.go
Outdated
| expectPDCfg = map[string]interface{}{ | ||
| "max-merge-region-keys": 0, | ||
| "max-merge-region-size": 0, | ||
| // TODO remove this schedule-limits, see https://github.com/pingcap/br/pull/555#discussion_r509855972 |
There was a problem hiding this comment.
as the rationale keeping the two -limits in #555 was
I think we could leave a TODO here and try to merge this firstly... I'm afraid that if any error occurs during editing, we cannot merge this in the current unstable CI environment...
do we still need to keep them here?
There was a problem hiding this comment.
There are some misunderstanding.
leader-schedule-limitandregion-schedule-limitdoes need in previous and current version to reduce the schedule. I'll update the comment later.- Before Persist temporary setting to etcd tikv/pd#3131
leader-schedule-limitandregion-schedule-limitdoesn't support ttl second. I think we should wait PD merge 3131 then test.
I want to make sure this PR is compatible with the old BR version and easy to support set pd ttl config. I'll file another PR to update config when 3131 merged.
Co-authored-by: kennytm <kennytm@gmail.com>
|
/rebuild |
|
/rebuild |
|
/rebuild |
1 similar comment
|
/rebuild |
kennytm
reviewed
Nov 16, 2020
|
/rebuild |
|
/run-integration-test |
3 similar comments
|
/run-integration-test |
|
/run-integration-test |
|
/run-integration-test |
|
/rebuild |
|
/run-integration-test |
|
LGTM |
ti-srebot
approved these changes
Nov 16, 2020
|
cherry pick to release-4.0 in PR #596 |
3pointer
added a commit
that referenced
this pull request
Nov 25, 2020
* pdutil: use temp pause config * refactor pdutil * fix ci * add pd version fail back * fix ci * fix ci * fix unmarshal bool * address comment * fi * add test case * Apply suggestions from code review Co-authored-by: kennytm <kennytm@gmail.com> * address comment * fix ci * update comment * update comment * Update pkg/pdutil/pd.go Co-authored-by: kennytm <kennytm@gmail.com> * address comment * change convoluted logic * resume config by set ttlSecond to 0 * test pause config * fix failpoint * update test * fix test Co-authored-by: luancheng <luancheng@pingcap.com> Co-authored-by: kennytm <kennytm@gmail.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After tikv/pd#3088 pd support set temporary config with ttlSecond. so BR can improve the behavior of pd config setting.
What is changed and how it works?
Check List
Tests
Code changes
Related changes
Release Note