Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: support temporary configuration (#3082) #3088

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3082 to release-4.0


What problem does this PR solve?

What is changed and how it works?

  1. Provide a temporary API to support temporary configuration for some configurations.

  2. Make /store/{id}/limit and /stores/limit support ttl param.

Note that this API is only supported for lightning and BR as a temporary way. Don't call this API.

As the temporary configuration only is saved in the memory, a recommended way to use API is calling it with short interval (once a minute) and long ttl (10 minutes).

Release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added component/api HTTP API. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Oct 21, 2020
@ti-srebot ti-srebot added this to the v4.0.8 milestone Oct 21, 2020
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Oct 22, 2020
@Yisaer Yisaer added the require-LGT1 Indicates that the PR requires an LGTM. label Oct 22, 2020
@Yisaer
Copy link
Contributor

Yisaer commented Oct 22, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 22, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@HunDunDM
Copy link
Member

This PR also contains #2697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants