This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
*: last bound source is prior to other source when pick for bound #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @lichunzhu |
lance6716
added
needs-cherry-pick-release-2.0
This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
status/PTAL
This PR is ready for review. Add this label back after committing new changes
and removed
status/WIP
This PR is still work in progress
labels
Jan 13, 2021
PTAL @GMHDBJD @lichunzhu |
don't forget to update keyslen |
GMHDBJD
reviewed
Jan 13, 2021
Should we delete last bound info when stop source? |
GMHDBJD
reviewed
Jan 14, 2021
GMHDBJD
reviewed
Jan 14, 2021
GMHDBJD
reviewed
Jan 14, 2021
GMHDBJD
reviewed
Jan 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GMHDBJD
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Jan 18, 2021
ping @lichunzhu |
PTAL @lichunzhu |
lichunzhu
approved these changes
Jan 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Jan 23, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-2.0 in PR #1397 |
ti-srebot
added
already-cherry-pick-2.0
The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked
and removed
needs-cherry-pick-release-2.0
This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0
labels
Jan 23, 2021
lance6716
pushed a commit
that referenced
this pull request
Jan 23, 2021
lance6716
removed
the
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
label
Feb 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-cherry-pick-2.0
The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
status/LGT1
One reviewer already commented LGTM
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
similar to #1044
when DM cluster restarts, worker is not likely keepalive when master goes to below logic, because etcd is in masters
dm/dm/master/scheduler/scheduler.go
Lines 924 to 936 in 49223f3
so worker is likely bounded to another source rather than its last source.
What is changed and how it works?
we always save a
lastBound
when do bounding, and not delete it. so whentryBoundForWorker
, we could prefer selecting the last bound source for worker.Also, if user didn't deploy more workers than sources, the bound relationship will not change (I hope)
Check List
Tests
Code changes
Side effects
Related changes