This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: last bound source is prior to other source when pick for bound (#1373) #1397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1373 to release-2.0
You can switch your code base to this Pull Request by using git-extras:
# In dm repo: git pr https://github.com/pingcap/dm/pull/1397
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
similar to #1044
when DM cluster restarts, worker is not likely keepalive when master goes to below logic, because etcd is in masters
dm/dm/master/scheduler/scheduler.go
Lines 924 to 936 in 49223f3
so worker is likely bounded to another source rather than its last source.
What is changed and how it works?
we always save a
lastBound
when do bounding, and not delete it. so whentryBoundForWorker
, we could prefer selecting the last bound source for worker.Also, if user didn't deploy more workers than sources, the bound relationship will not change (I hope)
Check List
Tests
Code changes
Side effects
Related changes