-
Notifications
You must be signed in to change notification settings - Fork 188
syncer: don't skip jobs from same event when comparing table checkpoint #1752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
@Ehco1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4c80409
|
In response to a cherrypick label: new pull request created: #1781. |
What problem does this PR solve?
close #1751
after
all_mode
paused, we could seet1 losts a row with id = 20 of https://github.com/pingcap/dm/pull/1752/files#diff-5cc7189b51f6219ea0ce1c9920f92f84cee41b3fee093894a72ca5ff1c615b4aR2
What is changed and how it works?
Check List
Tests
Code changes
Related changes